fix runLayer safety and release yoga-om-layer v2.0.0 (#1)

* fix runLayer safety for open rows

Prevent runLayer from accepting open requirement rows so missing dependencies fail at compile time instead of crashing at runtime. Add regression coverage for the bad case and preserve support for running closed-row layers with superset contexts.

* release v2.0.0

Bump yoga-om-layer to the new yoga-om 2.x dependency line and refresh the lockfile for the published resolver state.

Author: i-am-the-slime

compile-fail-tests/RunLayerOpenRowMissingDep.purs

@@ -0,0 +1,19 @@
+-- EXPECT: Prim.RowList.RowToList
+module Yoga.Om.Layer.CompileFailTest where
+
+import Prelude
+
+import Yoga.Om as Om
+import Yoga.Om.Layer (OmLayer, makeLayer, runLayer)
+
+type Fastify = String
+type Connection = String
+
+apiLayer :: forall r. OmLayer (fastify :: Fastify, sqlite :: Connection | r) () {}
+apiLayer = makeLayer do
+  { fastify, sqlite } <- Om.ask
+  let _ = fastify <> sqlite
+  pure {}
+
+bad :: Om.Om { fastify :: Fastify } () {}
+bad = runLayer { fastify: "server" } apiLayer

spago.lock

@@ -63,7 +63,7 @@
               "variant": ">=8.0.0 <9.0.0"
             },
             {
-              "yoga-om": ">=1.5.2 <2.0.0"
+              "yoga-om": ">=2.0.0 <3.0.0"
             }
           ]
         },
@@ -1225,8 +1225,8 @@
     },
     "yoga-om": {
       "type": "registry",
-      "version": "1.5.2",
-      "integrity": "sha256-2ys14BF6NPgzFDFUIFk0EDxmqkA8+yghIA9TXHlOmE0=",
+      "version": "2.0.0",
+      "integrity": "sha256-eenoujD2rJzR6gYJbbIiqLhXHC1C5dagu91HZkAEt/Y=",
       "dependencies": [
         "aff",
         "aff-retry",

spago.yaml

@@ -2,7 +2,7 @@ workspace: {}
 package:
   name: yoga-om-layer
   publish:
-    version: 1.2.2
+    version: 2.0.0
     license: MIT
     location:
       githubOwner: rowtype-yoga
@@ -27,7 +27,7 @@ package:
     - typelevel-prelude: ">=7.0.0 <8.0.0"
     - unsafe-coerce: ">=6.0.0 <7.0.0"
     - variant: ">=8.0.0 <9.0.0"
-    - yoga-om: ">=1.5.2 <2.0.0"
+    - yoga-om: ">=2.0.0 <3.0.0"
   test:
     main: Test.Main
     dependencies:

src/Yoga/Om/Layer.purs

@@ -340,9 +340,13 @@ else instance
 -- =============================================================================
 
 -- | Run a layer with a given context, with custom error if requirements aren't met.
+-- | `runLayer` requires a closed requirement row. If you have an open layer like
+-- | `OmLayer (db :: Db | r) err a`, specialize it to a closed row before running
+-- | it directly.
 runLayer
   :: forall req err a available
    . CheckAllProvided req available
+  => Keys req
   => Record available
   -> OmLayer req err a
   -> Om (Record available) err a

test/Test/Yoga/Om/Layer/InstancesSpec.purs

@@ -46,6 +46,18 @@ spec = do
       result <- Om.runOm {} { exception: \_ -> pure { result: 0 } } (runLayer {} layer)
       result.result `shouldEqual` 15
 
+    it "runs layers against a superset context" do
+      let
+        layer :: OmLayer (a :: Int) () { out :: Int }
+        layer = makeLayer do
+          { a } <- Om.ask
+          pure { out: a + 1 }
+
+        ctx = { a: 41, extra: "ok" }
+
+      result <- Om.runOm ctx { exception: \_ -> pure { out: 0 } } (runLayer ctx layer)
+      result.out `shouldEqual` 42
+
   describe "Parallel" do
 
     it "runs layers in parallel via parApply" do