Skip to content

Commit b804daf

Browse files
committed
add cargo-all-features to container
Some crates have a myriad of features, and it is very easy to accidentally mess up imports in a way that `cargo check --all-features` works, but only compiling with only a subset of features breaks. For this scenario, cargo check-all-features can help, as it will attempt to compile all feature permutations. We cannot currently add this to the default CI, as some crates in the rust-vmm ecosystem have incompatible features [1], but this unlocks at least testing all feature combinations for specific crates (for example, to ensure that no-std support does not accidentally break [2]). once the vm-memory / xen situation is fixed, this can also be added to the default CI. [1]: rust-vmm/vm-memory#317 [2]: rust-vmm/vm-allocator#107 Signed-off-by: Patrick Roy <[email protected]>
1 parent 0c7b147 commit b804daf

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

build_container.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ if [ "$ARCH" != "riscv64" ]; then
9797
popd
9898
fi
9999

100+
cargo install cargo-all-features
101+
100102
# Install some dependencies required by vhost-device crates but not available
101103
# in Ubuntu repos.
102104
# Some of these do not support riscv64, since vhost-device crates do not

0 commit comments

Comments
 (0)