Sync build system with latest OBS plugin template (#137)

* Initial plan

* Update build system from OBS plugin template: workflows, actions, and scripts

Co-authored-by: royshil <[email protected]>

* Add gersemi config and remove cmake-format config

Co-authored-by: royshil <[email protected]>

* Add .gersemirc to repository and update .gitignore

* Update README to reference new build-ubuntu script

Co-authored-by: royshil <[email protected]>

* Add explicit permissions to check-format workflow jobs for security

Co-authored-by: royshil <[email protected]>

* Update macOS CMake compiler config to match OBS plugin template

This fixes the macOS build failure by updating the SDK version check.
The template requires macOS SDK 15.0+ (Xcode 16.0+) which aligns with
the workflow update to use macOS-15 and Xcode 16.1.

Co-authored-by: royshil <[email protected]>

* Update OBS Studio and dependencies to version 31.1.1

This resolves the macOS build failure by updating to OBS Studio 31.1.1
which includes cmake infrastructure compatible with macOS 15 and Xcode 16.1.
Also updates prebuilt dependencies and Qt6 to 2025-07-11 to match the
template requirements.

Co-authored-by: royshil <[email protected]>

* Update jsoncons and inja submodules to latest versions

Updates jsoncons to latest (0dac681) which requires CMake 3.15+, fixing
the build error "Compatibility with CMake < 3.5 has been removed". The
old version required CMake 3.1 which is no longer supported.

Also updates inja to latest (ebb7aeb) for consistency and bug fixes.

Co-authored-by: royshil <[email protected]>

* Fix CMake presets and buildspec for cross-platform builds

- Rename Linux presets to Ubuntu presets (linux-* → ubuntu-*) to match
  template and build scripts expectations
- Update buildspec_common.cmake to match template, fixing:
  - Windows arch specification to include platform version
  - OBS CMake version to 3.0.0 for all platforms
  - ENABLE_UI → ENABLE_FRONTEND flag
  - Modern CMake return(PROPAGATE) syntax

This resolves Ubuntu preset not found error, and should fix Windows
libobs package discovery and macOS plugin-support build issues.

Co-authored-by: royshil <[email protected]>

* Replace deprecated obs_scene_sceneitem_from_source with obs_scene_find_source

OBS Studio 31.1.1 deprecated obs_scene_sceneitem_from_source(). Replaced
it with obs_scene_find_source() which finds scene items by source name
instead of source pointer. This fixes the Windows build error where
warnings are treated as errors.

Co-authored-by: royshil <[email protected]>

* Replace deprecated QCheckBox::stateChanged with checkStateChanged

Qt6 deprecated the stateChanged signal in favor of checkStateChanged.
Updated the signal connection to use the non-deprecated API. This fixes
the Windows build error where deprecation warnings are treated as errors.

Co-authored-by: royshil <[email protected]>

* Use QCheckBox::toggled instead of checkStateChanged for Qt6 compatibility

The checkStateChanged signal was added in Qt 6.7, but older Qt6 versions
on Ubuntu/macOS don't have it yet. Using the toggled signal instead, which
is available in all Qt versions and provides the same functionality for
checkboxes. This fixes the build error on Ubuntu and macOS while
maintaining Windows compatibility.

Co-authored-by: royshil <[email protected]>

* Update PugiXML to version 1.15 and change URL_HASH to SHA256

* Update CMake configuration files for various components

- Updated the Lexbor library version from v2.3.0 to v2.6.0 in BuildLexbor.cmake.
- Simplified FetchContent_Declare calls in BuildMyCurl.cmake for better readability.
- Improved formatting of CMake arguments in BuildPugiXML.cmake for consistency.
- Refactored JSON string extraction in FetchWebsocketpp.cmake for clarity.
- Enhanced error messaging in bootstrap.cmake for in-source build prohibition.
- Cleaned up build number cache definition in buildnumber.cmake for better readability.
- Standardized compiler options formatting in compiler_common.cmake and compilerconfig.cmake files.
- Improved helper function formatting in helpers_common.cmake for better readability.
- Streamlined toolchain files for aarch64 and x86_64 architectures by consolidating pkg-config executable definitions.
- Enhanced macOS buildspec and defaults files for better readability and consistency.
- Refactored install commands in windows helpers for improved clarity and consistency.

* Refactor formatting checks in .run-format.zsh and improve code readability in url-source-callbacks.cpp

* Add debug flag to clang-format run command for enhanced output

* Update clang-format action to remove debug flag and adjust Zsh version check

* Simplify Ubuntu build configuration by removing strategy matrix

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: royshil <[email protected]>
Co-authored-by: Roy Shilkrot <[email protected]>

Author: Copilot

.cmake-format.json

@@ -0,0 +1,8 @@
+# yaml-language-server: $schema=https://raw.githubusercontent.com/BlankSpruce/gersemi/master/gersemi/configuration.schema.json
+
+definitions: []
+line_length: 120
+indent: 2
+list_expansion: favour-inlining
+unsafe: false
+warn_about_unknown_commands: false

.gersemirc

@@ -1,23 +1,27 @@
-name: 'Set up and build plugin'
-description: 'Builds the plugin for specified architecture and build config'
+name: Set up and build plugin
+description: Builds the plugin for specified architecture and build config
 inputs:
   target:
-    description: 'Target architecture for dependencies'
+    description: Target architecture for dependencies
     required: true
   config:
-    description: 'Build configuration'
+    description: Build configuration
     required: false
-    default: 'RelWithDebInfo'
+    default: RelWithDebInfo
   codesign:
-    description: 'Enable codesigning (macOS only)'
+    description: Enable codesigning (macOS only)
     required: false
     default: 'false'
   codesignIdent:
-    description: 'Developer ID for application codesigning (macOS only)'
+    description: Developer ID for application codesigning (macOS only)
     required: false
     default: '-'
+  codesignTeam:
+    description: Team ID for application codesigning (macOS only)
+    required: false
+    default: ''
   workingDirectory:
-    description: 'Working directory for packaging'
+    description: Working directory for packaging
     required: false
     default: ${{ github.workspace }}
 runs:
@@ -28,6 +32,7 @@ runs:
       shell: zsh --no-rcs --errexit --pipefail {0}
       working-directory: ${{ inputs.workingDirectory }}
       env:
+        CCACHE_DIR: ${{ inputs.workingDirectory }}/.ccache
         CODESIGN_IDENT: ${{ inputs.codesignIdent }}
         CODESIGN_TEAM: ${{ inputs.codesignTeam }}
       run: |
@@ -55,16 +60,18 @@ runs:
       if: runner.os == 'Linux'
       shell: zsh --no-rcs --errexit --pipefail {0}
       working-directory: ${{ inputs.workingDirectory }}
+      env:
+        CCACHE_DIR: ${{ inputs.workingDirectory }}/.ccache
       run: |
         : Run Ubuntu Build
 
         local -a build_args=(
-          --target linux-${{ inputs.target }}
+          --target ubuntu-${{ inputs.target }}
           --config ${{ inputs.config }}
         )
         if (( ${+RUNNER_DEBUG} )) build_args+=(--debug)
 
-        .github/scripts/build-linux ${build_args}
+        .github/scripts/build-ubuntu ${build_args}
 
     - name: Run Windows Build
       if: runner.os == 'Windows'
@@ -86,7 +93,7 @@ runs:
       if: contains(fromJSON('["Linux", "macOS"]'),runner.os)
       shell: zsh --no-rcs --errexit --pipefail {0}
       env:
-        CCACHE_CONFIGPATH: ${{ inputs.workingDirectory }}/.ccache.conf
+        CCACHE_DIR: ${{ inputs.workingDirectory }}/.ccache
       run: |
         : Create Summary 📊
 

.github/actions/build-plugin/action.yaml

@@ -0,0 +1,77 @@
+name: Check For Changed Files
+description: Checks for changed files compared to specific git reference and glob expression
+inputs:
+  baseRef:
+    description: Git reference to check against
+    required: false
+  ref:
+    description: Git reference to check with
+    required: false
+    default: HEAD
+  checkGlob:
+    description: Glob expression to limit check to specific files
+    required: false
+  useFallback:
+    description: Use fallback compare against prior commit
+    required: false
+    default: 'true'
+  diffFilter:
+    description: git diff-filter string to use
+    required: false
+    default: ''
+outputs:
+  hasChangedFiles:
+    value: ${{ steps.checks.outputs.hasChangedFiles }}
+    description: True if specified files were changed in comparison to specified git reference
+  changedFiles:
+    value: ${{ steps.checks.outputs.changedFiles }}
+    description: List of changed files
+runs:
+  using: composite
+  steps:
+    - name: Check For Changed Files ✅
+      shell: bash
+      id: checks
+      env:
+        GIT_BASE_REF: ${{ inputs.baseRef }}
+        GIT_REF: ${{ inputs.ref }}
+        GITHUB_EVENT_FORCED: ${{ github.event.forced }}
+        GITHUB_REF_BEFORE: ${{ github.event.before }}
+        USE_FALLBACK: ${{ inputs.useFallback }}
+        DIFF_FILTER: ${{ inputs.diffFilter }}
+      run: |
+        : Check for Changed Files ✅
+        if [[ "${RUNNER_DEBUG}" ]]; then set -x; fi
+        shopt -s extglob
+        shopt -s dotglob
+
+        if [[ "${GIT_BASE_REF}" ]]; then
+          if ! git cat-file -e "${GIT_BASE_REF}" &> /dev/null; then
+            echo "::warning::Provided base reference ${GIT_BASE_REF} is invalid"
+            if [[ "${USE_FALLBACK}" == 'true' ]]; then
+              GIT_BASE_REF='HEAD~1'
+            fi
+          fi
+        else
+          if ! git cat-file -e ${GITHUB_REF_BEFORE} &> /dev/null; then
+            GITHUB_REF_BEFORE='4b825dc642cb6eb9a060e54bf8d69288fbee4904'
+          fi
+
+          GIT_BASE_REF='HEAD~1'
+          case "${GITHUB_EVENT_NAME}" in
+            pull_request) GIT_BASE_REF="origin/${GITHUB_BASE_REF}" ;;
+            push) if [[ "${GITHUB_EVENT_FORCED}" != 'true' ]]; then GIT_BASE_REF="${GITHUB_REF_BEFORE}"; fi ;;
+            *) ;;
+          esac
+        fi
+
+        changes=($(git diff --name-only --diff-filter="${DIFF_FILTER}" ${GIT_BASE_REF} ${GIT_REF} -- ${{ inputs.checkGlob }}))
+
+        if (( ${#changes[@]} )); then
+          file_string="${changes[*]}"
+          echo "hasChangedFiles=true" >> $GITHUB_OUTPUT
+          echo "changedFiles=[\"${file_string// /\",\"}\"]" >> $GITHUB_OUTPUT
+        else
+          echo "hasChangedFiles=false" >> $GITHUB_OUTPUT
+          echo "changedFiles=[]" >> GITHUB_OUTPUT
+        fi

.github/actions/check-changes/action.yaml

@@ -1,47 +1,47 @@
-name: 'Package plugin'
-description: 'Packages the plugin for specified architecture and build config.'
+name: Package plugin
+description: Packages the plugin for specified architecture and build config.
 inputs:
   target:
-    description: 'Build target for dependencies'
+    description: Build target for dependencies
     required: true
   config:
-    description: 'Build configuration'
+    description: Build configuration
     required: false
-    default: 'RelWithDebInfo'
+    default: RelWithDebInfo
   codesign:
-    description: 'Enable codesigning (macOS only)'
+    description: Enable codesigning (macOS only)
     required: false
     default: 'false'
   notarize:
-    description: 'Enable notarization (macOS only)'
+    description: Enable notarization (macOS only)
     required: false
     default: 'false'
   codesignIdent:
-    description: 'Developer ID for application codesigning (macOS only)'
+    description: Developer ID for application codesigning (macOS only)
     required: false
     default: '-'
   installerIdent:
-    description: 'Developer ID for installer package codesigning (macOS only)'
+    description: Developer ID for installer package codesigning (macOS only)
     required: false
     default: ''
   codesignTeam:
-    description: 'Developer team for codesigning (macOS only)'
+    description: Developer team for codesigning (macOS only)
     required: false
     default: ''
   codesignUser:
-    description: 'Apple ID username for notarization (macOS only)'
+    description: Apple ID username for notarization (macOS only)
     required: false
     default: ''
   codesignPass:
-    description: 'Apple ID password for notarization (macOS only)'
+    description: Apple ID password for notarization (macOS only)
     required: false
     default: ''
   package:
-    description: 'Create Windows or macOS installation package'
+    description: Create Windows or macOS installation package
     required: false
     default: 'false'
   workingDirectory:
-    description: 'Working directory for packaging'
+    description: Working directory for packaging
     required: false
     default: ${{ github.workspace }}
 runs:
@@ -87,14 +87,14 @@ runs:
       run: |
         : Run Ubuntu Packaging
         package_args=(
-          --target linux-${{ inputs.target }}
+          --target ubuntu-${{ inputs.target }}
           --config ${{ inputs.config }}
         )
         if (( ${+RUNNER_DEBUG} )) build_args+=(--debug)
 
         if [[ '${{ inputs.package }}' == 'true' ]] package_args+=(--package)
 
-        .github/scripts/package-linux ${package_args}
+        .github/scripts/package-ubuntu ${package_args}
 
     - name: Run Windows Packaging
       if: runner.os == 'Windows'
@@ -110,8 +110,4 @@ runs:
           Configuration = '${{ inputs.config }}'
         }
 
-        if ( '${{ inputs.package }}' -eq 'true' ) {
-          $PackageArgs += @{BuildInstaller = $true}
-        }
-
         .github/scripts/Package-Windows.ps1 @PackageArgs

.github/actions/package-plugin/action.yaml

@@ -4,7 +4,7 @@ inputs:
   failCondition:
     description: Controls whether failed checks also fail the workflow run
     required: false
-    default: 'never'
+    default: never
   workingDirectory:
     description: Working directory for checks
     required: false
@@ -20,42 +20,41 @@ runs:
         echo "::notice::run-clang-format action requires a macOS-based or Linux-based runner."
         exit 2
 
+    - name: Check for Changed Files ✅
+      uses: ./.github/actions/check-changes
+      id: checks
+      with:
+        checkGlob: "'*.c' '*.h' '*.cpp' '*.hpp' '*.m' '*.mm'"
+        diffFilter: 'ACM'
+
     - name: Install Dependencies 🛍️
-      if: runner.os == 'Linux'
+      if: runner.os == 'Linux' && fromJSON(steps.checks.outputs.hasChangedFiles)
       shell: bash
       run: |
         : Install Dependencies 🛍️
         echo ::group::Install Dependencies
         eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
         echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
-        echo "/home/linuxbrew/.linuxbrew/opt/clang-format@17/bin" >> $GITHUB_PATH
+        echo "/home/linuxbrew/.linuxbrew/opt/clang-format@19/bin" >> $GITHUB_PATH
         brew install --quiet zsh
         echo ::endgroup::
 
     - name: Run clang-format 🐉
+      if: fromJSON(steps.checks.outputs.hasChangedFiles)
       id: result
       shell: zsh --no-rcs --errexit --pipefail {0}
       working-directory: ${{ inputs.workingDirectory }}
       env:
-        GITHUB_EVENT_FORCED: ${{ github.event.forced }}
-        GITHUB_REF_BEFORE: ${{ github.event.before }}
+        CHANGED_FILES: ${{ steps.checks.outputs.changedFiles }}
       run: |
         : Run clang-format 🐉
         if (( ${+RUNNER_DEBUG} )) setopt XTRACE
 
-        local -a changes=($(git diff --name-only HEAD~1 HEAD))
-        case ${GITHUB_EVENT_NAME} {
-          pull_request) changes=($(git diff --name-only origin/${GITHUB_BASE_REF} HEAD)) ;;
-          push) if [[ ${GITHUB_EVENT_FORCED} != true ]] changes=($(git diff --name-only ${GITHUB_REF_BEFORE} HEAD)) ;;
-          *) ;;
-        }
-
-        if (( ${changes[(I)(*.c|*.h|*.cpp|*.hpp|*.m|*.mm)]} )) {
-          echo ::group::Install clang-format-17
-          brew install --quiet obsproject/tools/clang-format@17
-          echo ::endgroup::
+        print ::group::Install clang-format-19
+        brew install --quiet obsproject/tools/clang-format@19
+        print ::endgroup::
 
-          echo ::group::Run clang-format-17
-          ./build-aux/run-clang-format --fail-${{ inputs.failCondition }} --check
-          echo ::endgroup::
-        }
+        print ::group::Run clang-format-19
+        local -a changes=(${(s:,:)CHANGED_FILES//[\[\]\'\"]/})
+        ./build-aux/run-clang-format --fail-${{ inputs.failCondition }} --check ${changes}
+        print ::endgroup::