chore: update rust and deny check (#118)

* chore: update rust and deny check

* chore: bump jet to v0.2.0

* chore: ignore bincode discontinued

* chore: remove protoc

* chore: fix clippy warnings

Author: leafaar

.github/workflows/test.yml

@@ -67,15 +67,10 @@ jobs:
         run: cargo +nightly fmt --all -- --check
 
       - name: cargo deny check advisories
-        uses: EmbarkStudios/cargo-deny-action@v1
+        uses: EmbarkStudios/cargo-deny-action@v2
         with:
           command: check advisories
 
-      - name: install protoc
-        run: |
-          sudo apt update
-          sudo apt install protobuf-compiler
-
       - name: Run clippy
         run: cargo clippy --all-targets --tests --all-features -- -Dwarnings
 

Cargo.lock

@@ -108,7 +108,7 @@ tonic-prost-build = "0.14.0"
 vergen = "9.0.1"
 tikv-jemallocator = "0.6.1"
 libc = "0.2.177"
-yellowstone-jet-tpu-client = { path = "crates/tpu-client", version = "0.1.0-rc1" }
+yellowstone-jet-tpu-client = { path = "crates/tpu-client", version = "0.2.0" }
 
 [workspace.lints.clippy]
 clone_on_ref_ptr = "deny"
@@ -131,4 +131,4 @@ solana-transaction-status = { git = "https://github.com/rpcpool/solana-public.gi
 solana-transaction-status-client-types = { git = "https://github.com/rpcpool/solana-public.git", tag = "v3.0.6-triton-public" }
 solana-net-utils   = { git = "https://github.com/rpcpool/solana-public.git", tag = "v3.0.6-triton-public" }
 solana-tpu-client  = { git = "https://github.com/rpcpool/solana-public.git", tag = "v3.0.6-triton-public" }
-solana-quic-client = { git = "https://github.com/rpcpool/solana-public.git", tag = "v3.0.6-triton-public" }
+solana-quic-client = { git = "https://github.com/rpcpool/solana-public.git", tag = "v3.0.6-triton-public" }

Cargo.toml

@@ -109,7 +109,7 @@ impl Config {
         let path = path.as_ref();
         let contents = fs::read(path)
             .await
-            .with_context(|| format!("failed to read config from {:?}", path))?;
+            .with_context(|| format!("failed to read config from {path:?}"))?;
         Ok(serde_yaml::from_slice(&contents)?)
     }
 
@@ -208,7 +208,7 @@ impl TransactionSender {
                             encoded_tx,
                             {
                                 "skipPreflight": config.config.skip_preflight,
-                                "preflightCommitment": config.config.preflight_commitment.map(|c| format!("{:?}", c).to_lowercase()),
+                                "preflightCommitment": config.config.preflight_commitment.map(|c| format!("{c:?}").to_lowercase()),
                                 "encoding": "base64",
                                 "maxRetries": config.config.max_retries,
                                 "minContextSlot": config.config.min_context_slot,
@@ -227,7 +227,7 @@ impl TransactionSender {
                         .await?;
 
                     if let Some(err) = response.get("error") {
-                        return Err(anyhow::anyhow!("RPC error: {:?}", err));
+                        return Err(anyhow::anyhow!("RPC error: {err:?}"));
                     }
 
                     if let Some(result) = response.get("result") {

apps/jet/src/bin/gentx.rs

@@ -556,15 +556,15 @@ where
                 port,
             ))),
             Value::Env { env } => std::env::var(env)
-                .map_err(|error| format!("{:}", error))
+                .map_err(|error| format!("{error:}"))
                 .and_then(|value| match value.parse() {
                     Ok(addr) => Ok(addr),
                     Err(error) => match value.parse() {
                         Ok(port) => Ok(SocketAddr::V4(SocketAddrV4::new(
                             Ipv4Addr::new(0, 0, 0, 0),
                             port,
                         ))),
-                        Err(_) => Err(format!("{:?}", error)),
+                        Err(_) => Err(format!("{error:?}")),
                     },
                 })
                 .map_err(de::Error::custom),

apps/jet/src/config.rs

@@ -103,7 +103,7 @@ struct SlotTrackingInfo {
 }
 
 impl SlotTrackingInfo {
-    fn mark_status_seen(&mut self, status: SlotStatus) {
+    const fn mark_status_seen(&mut self, status: SlotStatus) {
         self.statuses_seen |= 1 << (status as i32 as u8);
     }
 
@@ -711,7 +711,7 @@ impl GeyserSubscriber {
         let response = geyser
             .get_version()
             .await
-            .map_err(|e| GeyserError::GrpcClient(format!("failed to get version: {}", e)))?;
+            .map_err(|e| GeyserError::GrpcClient(format!("failed to get version: {e}")))?;
 
         let version = match serde_json::from_str::<GrpcVersion>(&response.version)? {
             GrpcVersion::Old(s) => s.version,
@@ -720,13 +720,12 @@ impl GeyserSubscriber {
 
         let version = Version::parse(&version)?;
         let required = VersionReq::parse(">=1.14.1").map_err(|e| {
-            GeyserError::VersionParse(format!("failed to parse required version: {}", e))
+            GeyserError::VersionParse(format!("failed to parse required version: {e}"))
         })?;
 
         if !required.matches(&version) {
             return Err(GeyserError::VersionValidation(format!(
-                "gRPC version {} doesn't match required {}",
-                version, required
+                "gRPC version {version} doesn't match required {required}"
             )));
         }
 

apps/jet/src/grpc_geyser.rs

@@ -234,8 +234,7 @@ pub async fn grpc_subscribe_jet_gw(
         Ok(resp) => resp.into_inner(),
         Err(status) => {
             return Err(anyhow::anyhow!(
-                "Failed to establish subscription: {}",
-                status
+                "Failed to establish subscription: {status}"
             ));
         }
     };
@@ -271,7 +270,7 @@ pub async fn grpc_subscribe_jet_gw(
     };
 
     if let Err(e) = init_tx.clone().send(limit_message).await {
-        return Err(anyhow::anyhow!("Failed to send rate limit message: {}", e));
+        return Err(anyhow::anyhow!("Failed to send rate limit message: {e}"));
     }
 
     // Forward remaining messages

apps/jet/src/grpc_jet.rs

@@ -244,7 +244,7 @@ impl OneTimeAuthTokenStore for InMemoryTokenStore {
         let expire_at = Instant::now() + ttl;
         let mut inner = self.inner.lock().await;
         if let Some(old) = inner.insert(token.clone(), (pubkey, expire_at)) {
-            panic!("Token collision: with {:?}", old);
+            panic!("Token collision: with {old:?}");
         }
 
         // Here we garbage collect expired tokens

apps/jet/src/pubkey_challenger.rs

@@ -222,7 +222,7 @@ impl RefreshStakeInfoMapTask {
                     tracing::error!("Failed to get epoch info: {:?}", err);
                     return;
                 } else {
-                    panic!("Failed to get epoch info: {:?}", err);
+                    panic!("Failed to get epoch info: {err:?}");
                 }
             }
         };
@@ -248,7 +248,7 @@ impl RefreshStakeInfoMapTask {
                 if err.is_transient() {
                     tracing::error!("Failed to get vote accounts: {:?}", err);
                 } else {
-                    panic!("Failed to get vote accounts: {:?}", err);
+                    panic!("Failed to get vote accounts: {err:?}");
                 }
             }
         }

apps/jet/src/stake.rs

@@ -142,7 +142,7 @@ impl IncrementalBackoff {
         }
     }
 
-    pub fn reset(&mut self) {
+    pub const fn reset(&mut self) {
         self.retries = None;
     }