Merge pull request #1459 from rpm-software-management/no-man-pip3

FilesCheck: fix manpage regex to support numbers

Author: danigm

rpmlint/checks/FilesCheck.py

@@ -204,7 +204,7 @@
 non_readable_regexs = (re.compile(r'^/var/log/'),
                        re.compile(r'^/etc/(g?shadow-?|securetty)$'))
 
-man_base_regex = re.compile(r'^/usr(?:/share)?/man(?:/overrides)?/man(?P<category>[^/]+)/(?P<filename>((?P<binary>[^.]+)\..+))')
+man_base_regex = re.compile(r'^/usr(?:/share)?/man(?:/overrides)?/man(?P<category>[^/]+)/(?P<filename>((?P<binary>.+)\.\d.*))')
 
 fsf_license_regex = re.compile(br'(GNU((\s+(Library|Lesser|Affero))?(\s+General)?\s+Public|\s+Free\s+Documentation)\s+Licen[cs]e|(GP|FD)L)', re.IGNORECASE)
 fsf_wrong_address_regex = re.compile(br'(675\s+Mass\s+Ave|59\s+Temple\s+Place|02139|51\s+Franklin\s+St)', re.IGNORECASE)

test/mockdata/mock_files.py

@@ -219,6 +219,26 @@
 )
 
 
+Pip3ManPagesPackage = get_tested_mock_package(
+    lazyload=True,
+    files={
+        '/usr/bin/pip': {'content': '', 'metadata': {'mode': 0o755 | stat.S_IFREG}},
+        '/usr/bin/pip3': {'content': '', 'metadata': {'mode': 0o755 | stat.S_IFREG}},
+        '/usr/bin/pip3.13': {'content': '', 'metadata': {'mode': 0o755 | stat.S_IFREG}},
+        '/usr/bin/pip3.13.3': {'content': '', 'metadata': {'mode': 0o755 | stat.S_IFREG}},
+        '/usr/bin/pip3.14': {'content': '', 'metadata': {'mode': 0o755 | stat.S_IFREG}},
+        '/usr/bin/pip-3.14': {'content': '', 'metadata': {'mode': 0o755 | stat.S_IFREG}},
+        '/usr/share/man/man1/pip.2': {'content': 'text'},
+        '/usr/share/man/man1/pip3.1posix': {'content': 'text'},
+        '/usr/share/man/man1/pip3.13.1': {'content': 'text'},
+        '/usr/share/man/man1/pip3.13.3.1posix.xz': {'content': 'xz'},
+        '/usr/share/man/man1/pip3.14.1.gz': {'content': 'gz'},
+        '/usr/share/man/man1/pip-3.14.1.gz': {'content': 'gz'},
+    },
+    header={'requires': []},
+)
+
+
 DevelopmentPackage = get_tested_mock_package(
     lazyload=True,
     name='my-package-devel',

test/test_files.py

@@ -14,6 +14,7 @@
     ManualPagesPackage,
     NetmaskDebugsourcePackage,
     NonReadableGhostPackage,
+    Pip3ManPagesPackage,
     Python3PowerBrokenPackage,
     Python3PowerPackage,
     PythonShebangLinkOkPackage,
@@ -238,6 +239,14 @@ def test_manpages(package, filescheck):
     assert 'This manual page is not compressed with the bz2 compression' in out
 
 
+@pytest.mark.parametrize('package', [Pip3ManPagesPackage])
+def test_manpages_pip3(package, filescheck):
+    output, test = filescheck
+    test.check(package)
+    out = output.print_results(output.results)
+    assert 'no-manual-page-for-binary' not in out
+
+
 @pytest.mark.parametrize('package', [DevelopmentPackage])
 def test_provides_devel(package, filescheck):
     output, test = filescheck