Removed unsound Send + Sync

Author: Sytten

Cargo.toml

@@ -14,5 +14,5 @@ edition = "2021"
 rquickjs = { version = "0.8.1", features = ["loader"] }
 
 [dev-dependencies]
-rquickjs = { version = "0.8.1", features = ["futures", "macro"] }
+rquickjs = { version = "0.8.1", features = ["futures", "macro", "parallel"] }
 tokio = { version = "1", features = ["full"] }

src/loader/builder.rs

@@ -52,7 +52,7 @@ impl ModuleLoaderBuilder {
     #[must_use]
     pub fn with_module<O, M, R>(mut self, module: M) -> Self
     where
-        for<'js> O: JsLifetime<'js> + 'static,
+        for<'js> O: JsLifetime<'js> + Send + Sync + 'static,
         R: ModuleDef + ModuleMeta,
         M: IntoModule<O, R>,
     {
@@ -63,7 +63,7 @@ impl ModuleLoaderBuilder {
     #[must_use]
     pub fn with_module_named<O, M, R>(mut self, module: M, name: &'static str) -> Self
     where
-        for<'js> O: JsLifetime<'js> + 'static,
+        for<'js> O: JsLifetime<'js> + Send + Sync + 'static,
         R: ModuleDef + ModuleMeta,
         M: IntoModule<O, R>,
     {
@@ -73,7 +73,7 @@ impl ModuleLoaderBuilder {
 
     pub fn add_module<O, M, R>(&mut self, module: M) -> &mut Self
     where
-        for<'js> O: JsLifetime<'js> + 'static,
+        for<'js> O: JsLifetime<'js> + Send + Sync + 'static,
         R: ModuleDef + ModuleMeta,
         M: IntoModule<O, R>,
     {
@@ -82,7 +82,7 @@ impl ModuleLoaderBuilder {
 
     pub fn add_module_named<O, M, R>(&mut self, module: M, name: &'static str) -> &mut Self
     where
-        for<'js> O: JsLifetime<'js> + 'static,
+        for<'js> O: JsLifetime<'js> + Send + Sync + 'static,
         R: ModuleDef + ModuleMeta,
         M: IntoModule<O, R>,
     {
@@ -91,7 +91,7 @@ impl ModuleLoaderBuilder {
 
     fn process_module<O, M, R>(&mut self, module: M, name: Option<&'static str>) -> &mut Self
     where
-        for<'js> O: JsLifetime<'js> + 'static,
+        for<'js> O: JsLifetime<'js> + Send + Sync + 'static,
         R: ModuleDef + ModuleMeta,
         M: IntoModule<O, R>,
     {

src/loader/global.rs

@@ -6,9 +6,6 @@ pub struct GlobalInitializer {
     globals: Vec<GlobalLoadFn>,
 }
 
-unsafe impl Send for GlobalInitializer {}
-unsafe impl Sync for GlobalInitializer {}
-
 impl GlobalInitializer {
     pub(crate) fn new(globals: Vec<GlobalLoadFn>) -> Self {
         Self { globals }

src/loader/mod.rs

@@ -10,7 +10,7 @@ mod builder;
 mod global;
 mod resolver;
 
-type GlobalLoadFn = Box<dyn for<'js> FnOnce(&Ctx<'js>, &Object<'js>) -> Result<()>>;
+type GlobalLoadFn = Box<dyn for<'js> FnOnce(&Ctx<'js>, &Object<'js>) -> Result<()> + Send + Sync>;
 type ModuleLoadFn = for<'js> fn(Ctx<'js>, Vec<u8>) -> Result<Module<'js>>;
 
 /// Loader for Rust modules defined using [`crate::ModuleDefExt`].