Update in-favorites test for non-library songs.

rudrankriyam · rudrankriyam · commit c069d67da23c · 2026-01-26T18:59:47.000+05:30
The API now returns a false flag rather than throwing when a song isn't in the library.
diff --git a/Tests/MusadoraKitTests/Library/InFavoritesTests.swift b/Tests/MusadoraKitTests/Library/InFavoritesTests.swift
@@ -60,7 +60,7 @@ struct InFavoritesTests {
   }
 
   @Test
-  func songNotInLibraryThrowsError() throws {
+  func songNotInLibraryReturnsFalse() throws {
     let json = """
     {
       "data": [{
@@ -80,10 +80,9 @@ struct InFavoritesTests {
     """
 
     let data = try #require(json.data(using: .utf8))
+    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .songs)
 
-    #expect(throws: MusadoraKitError.self) {
-      try InFavoritesParser.parse(from: data, itemType: .songs)
-    }
+    #expect(inFavorites == false)
   }
 
   // MARK: - Album Tests

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ struct InFavoritesTests {`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`@Test`
`63`		`- func songNotInLibraryThrowsError() throws {`
	`63`	`+ func songNotInLibraryReturnsFalse() throws {`
`64`	`64`	`let json = """`
`65`	`65`	`{`
`66`	`66`	`"data": [{`
`@@ -80,10 +80,9 @@ struct InFavoritesTests {`
`80`	`80`	`"""`
`81`	`81`
`82`	`82`	`let data = try #require(json.data(using: .utf8))`
	`83`	`+ let inFavorites = try InFavoritesParser.parse(from: data, itemType: .songs)`
`83`	`84`
`84`		`- #expect(throws: MusadoraKitError.self) {`
`85`		`- try InFavoritesParser.parse(from: data, itemType: .songs)`
`86`		`- }`
	`85`	`+ #expect(inFavorites == false)`
`87`	`86`	`}`
`88`	`87`
`89`	`88`	`// MARK: - Album Tests`