Remove unused LibraryItemWrapper and refactor to use existing LibraryMusicItemType

- Remove unused LibraryItemWrapper.swift file
- Remove custom MusicItemType enum
- Use existing LibraryMusicItemType instead (songs, albums, artists, playlists, musicVideos)
- Remove redundant extend=inFavorites query parameters from playlist methods
- Update path construction to use rawValue directly (already pluralized)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: rudrankriyam

Sources/MusadoraKit/Library/InFavoritesParser.swift

@@ -7,15 +7,6 @@
 
 import Foundation
 
-/// The type of music item being parsed for inFavorites status.
-internal enum MusicItemType: String {
-  case song
-  case album
-  case artist
-  case playlist
-  case musicVideo = "music-video"
-}
-
 /// Response structure for Apple Music API inFavorites queries.
 private struct InFavoritesResponse: Decodable {
   let data: [InFavoritesResponseItem]
@@ -51,7 +42,7 @@ internal enum InFavoritesParser {
   ///   - itemType: The type of music item being parsed
   /// - Returns: The inFavorites boolean value
   /// - Throws: MusadoraKitError if parsing fails, item not found, not in library, or inFavorites not found
-  static func parse(from data: Data, itemType: MusicItemType) throws -> Bool {
+  static func parse(from data: Data, itemType: LibraryMusicItemType) throws -> Bool {
     let response = try JSONDecoder().decode(InFavoritesResponse.self, from: data)
 
     guard let item = response.data.first else {
@@ -78,10 +69,10 @@ internal enum InFavoritesParser {
   ///   - itemType: The type of music item
   /// - Returns: `true` if the item is in favorites, `false` otherwise
   /// - Throws: An error if the item is not in library or if the request fails
-  static func fetchInFavorites(for id: MusicItemID, itemType: MusicItemType) async throws -> Bool {
+  static func fetchInFavorites(for id: MusicItemID, itemType: LibraryMusicItemType) async throws -> Bool {
     let storefront = try await MusicDataRequest.currentCountryCode
     var components = AppleMusicURLComponents()
-    components.path = "catalog/\(storefront)/\(itemType.rawValue)s/\(id.rawValue)"
+    components.path = "catalog/\(storefront)/\(itemType.rawValue)/\(id.rawValue)"
     components.queryItems = [
       URLQueryItem(name: "relate", value: "library"),
       URLQueryItem(name: "extend", value: "inFavorites")

Sources/MusadoraKit/Library/MLibrary+Album.swift

@@ -226,7 +226,7 @@ public extension Album {
   var inFavorites: Bool {
     get async throws {
       let catalogId = try self.catalogID
-      return try await InFavoritesParser.fetchInFavorites(for: catalogId, itemType: .album)
+      return try await InFavoritesParser.fetchInFavorites(for: catalogId, itemType: .albums)
     }
   }
 }

Sources/MusadoraKit/Library/MLibrary+Artist.swift

@@ -158,7 +158,7 @@ public extension Artist {
   /// - Throws: An error if the artist is not in library or if the request fails.
   var inFavorites: Bool {
     get async throws {
-      return try await InFavoritesParser.fetchInFavorites(for: id, itemType: .artist)
+      return try await InFavoritesParser.fetchInFavorites(for: id, itemType: .artists)
     }
   }
 }

Sources/MusadoraKit/Library/MLibrary+Playlist.swift

@@ -328,7 +328,7 @@ public extension Playlist {
   /// - Throws: An error if the playlist is not in library or if the request fails.
   var inFavorites: Bool {
     get async throws {
-      return try await InFavoritesParser.fetchInFavorites(for: id, itemType: .playlist)
+      return try await InFavoritesParser.fetchInFavorites(for: id, itemType: .playlists)
     }
   }
 }

Sources/MusadoraKit/Library/MLibrary+Song.swift

@@ -518,7 +518,7 @@ public extension Song {
         throw MusadoraKitError.notFound(for: "catalogId")
       }
 
-      return try await InFavoritesParser.fetchInFavorites(for: catalogId, itemType: .song)
+      return try await InFavoritesParser.fetchInFavorites(for: catalogId, itemType: .songs)
     }
   }
 }

Tests/MusadoraKitTests/Library/InFavoritesTests.swift

@@ -28,7 +28,7 @@ struct InFavoritesTests {
     """
 
     let data = try #require(json.data(using: .utf8))
-    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .song)
+    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .songs)
 
     #expect(inFavorites == true)
   }
@@ -54,7 +54,7 @@ struct InFavoritesTests {
     """
 
     let data = try #require(json.data(using: .utf8))
-    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .song)
+    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .songs)
 
     #expect(inFavorites == false)
   }
@@ -82,7 +82,7 @@ struct InFavoritesTests {
     let data = try #require(json.data(using: .utf8))
 
     #expect(throws: MusadoraKitError.self) {
-      try InFavoritesParser.parse(from: data, itemType: .song)
+      try InFavoritesParser.parse(from: data, itemType: .songs)
     }
   }
 
@@ -109,7 +109,7 @@ struct InFavoritesTests {
     """
 
     let data = try #require(json.data(using: .utf8))
-    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .album)
+    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .albums)
 
     #expect(inFavorites == true)
   }
@@ -137,7 +137,7 @@ struct InFavoritesTests {
     """
 
     let data = try #require(json.data(using: .utf8))
-    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .artist)
+    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .artists)
 
     #expect(inFavorites == true)
   }
@@ -165,7 +165,7 @@ struct InFavoritesTests {
     """
 
     let data = try #require(json.data(using: .utf8))
-    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .playlist)
+    let inFavorites = try InFavoritesParser.parse(from: data, itemType: .playlists)
 
     #expect(inFavorites == true)
   }
@@ -194,7 +194,7 @@ struct InFavoritesTests {
     let data = try #require(json.data(using: .utf8))
 
     #expect(throws: MusadoraKitError.self) {
-      try InFavoritesParser.parse(from: data, itemType: .song)
+      try InFavoritesParser.parse(from: data, itemType: .songs)
     }
   }
 
@@ -209,7 +209,7 @@ struct InFavoritesTests {
     let data = try #require(json.data(using: .utf8))
 
     #expect(throws: MusadoraKitError.self) {
-      try InFavoritesParser.parse(from: data, itemType: .song)
+      try InFavoritesParser.parse(from: data, itemType: .songs)
     }
   }
 }