Skip to content

Replace root logger with module-specific one #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace root logger with module-specific one #4

wants to merge 2 commits into from

Conversation

timurlenk07
Copy link

Logging via the root logger is a discouraged behaviour, since the end-user does not have a way to influence the level and handlers (and other details) of log messages of the specific module. See here.

In this PR, I replace the logging calls with calls on a module level logger instance.

@pezosanta
Copy link

Hi @rshipp and @george2,

Could any of you please accept this PR ASAP? This way logging level configuration of python-nut2 works as a charm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timurlenk07 @pezosanta