Add tests

Author: abdullahkady

tests/testapp/tests/test_mixin.py

@@ -316,6 +316,24 @@ def test_changes_to_condition_should_pass(self):
             user_account.last_name = "Flanders"
             user_account.save()
 
+    def test_changes_to_condition_included_in_update_fields_should_fire_hook(self):
+        user_account = UserAccount.objects.create(**self.stub_data)
+        user_account.first_name = "Flanders"
+        user_account.last_name = "Flanders"
+        with self.assertRaises(CannotRename, msg="Oh, not Flanders. Anybody but Flanders."):
+            user_account.last_name = "Flanders"
+            user_account.save(update_fields=["last_name"])
+
+    def test_changes_to_condition_not_included_in_update_fields_should_not_fire_hook(self):
+        user_account = UserAccount.objects.create(**self.stub_data)
+        user_account.first_name = "Flanders"
+        user_account.last_name = "Flanders"
+        user_account.save(update_fields=["first_name"])  # `CannotRename` exception is not raised
+
+        user_account.refresh_from_db()
+        self.assertEqual(user_account.first_name, "Flanders")
+        self.assertNotEqual(user_account.last_name, "Flanders")
+
     def test_changes_to_condition_should_not_pass(self):
         data = self.stub_data
         data["first_name"] = "Marge"

tests/testapp/tests/test_user_account.py

@@ -117,6 +117,43 @@ def test_email_user_about_name_change(self):
             mail.outbox[0].body, "You changed your first name or your last name"
         )
 
+    def test_does_not_email_user_about_name_change_when_name_excluded_from_update_fields(self):
+        account = UserAccount.objects.create(**self.stub_data)
+        mail.outbox = []
+        account.first_name = "Homer the Great"
+        account.password = "New password!"
+
+        old_password_updated_at = account.password_updated_at
+        account.save(update_fields=["password"])
+        self.assertEqual(len(mail.outbox), 0)  # `first_name` change was skipped (as a hook).
+        self.assertNotEqual(account.password_updated_at, old_password_updated_at)  # Ensure the other hook is fired.
+
+    def test_emails_user_about_name_change_when_one_field_from_update_fields_intersects_with_condition(self):
+        account = UserAccount.objects.create(**self.stub_data)
+        mail.outbox = []
+        account.first_name = "Homer the Great"
+        account.password = "New password!"
+
+        old_password_updated_at = account.password_updated_at
+        account.save(update_fields=["first_name", "password"])
+        self.assertEqual(
+            mail.outbox[0].body, "You changed your first name or your last name"
+        )
+        self.assertNotEqual(account.password_updated_at, old_password_updated_at)  # Both hooks fired.
+
+    def test_empty_update_fields_does_not_fire_any_hooks(self):
+        # In Django, an empty list supplied to `update_fields` means not updating any field.
+        account = UserAccount.objects.create(**self.stub_data)
+        mail.outbox = []
+        account.first_name = "Flanders"
+        account.password = "new pass"
+
+        old_password_updated_at = account.password_updated_at
+        account.save(update_fields=[])
+        # Did not raise, so last name hook didn't fire.
+        self.assertEqual(len(mail.outbox), 0)
+        self.assertEqual(account.password_updated_at, old_password_updated_at)  # Password hook didn't fire either.
+
     def test_skip_hooks(self):
         """
         Hooked method that auto-lowercases email should be skipped.