Skip to content

Commit 7bc565a

Browse files
authored
Merge pull request #93 from nextmat/packaging_version
Switching from distutils to packaging.version for version checking
2 parents ded63d0 + ae9ac1b commit 7bc565a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

django_lifecycle/django_info.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
from distutils.version import StrictVersion
1+
from packaging.version import Version
22

33
import django
44

55
DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES = []
66

7-
if StrictVersion(django.__version__) < StrictVersion("1.9"):
7+
if Version(django.__version__) < Version("1.9"):
88
from django.db.models.fields.related import (
99
SingleRelatedObjectDescriptor,
1010
ReverseSingleRelatedObjectDescriptor,
@@ -23,7 +23,7 @@
2323
]
2424
)
2525

26-
if StrictVersion(django.__version__) >= StrictVersion("1.9"):
26+
if Version(django.__version__) >= Version("1.9"):
2727
from django.db.models.fields.related_descriptors import (
2828
ForwardManyToOneDescriptor,
2929
ReverseOneToOneDescriptor,
@@ -40,11 +40,11 @@
4040
]
4141
)
4242

43-
if StrictVersion(django.__version__) >= StrictVersion("1.11"):
43+
if Version(django.__version__) >= Version("1.11"):
4444
from django.db.models.fields.related_descriptors import ForwardOneToOneDescriptor
4545

4646
DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES.extend([ForwardOneToOneDescriptor])
4747

4848

4949
DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES = tuple(DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES)
50-
IS_GTE_1_POINT_9 = StrictVersion(django.__version__) >= StrictVersion("1.9")
50+
IS_GTE_1_POINT_9 = Version(django.__version__) >= Version("1.9")

tests/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"""
1212

1313
import os
14-
from distutils.version import StrictVersion
14+
from packaging.version import Version
1515

1616
import django
1717

@@ -43,7 +43,7 @@
4343
]
4444

4545
# Django 1.8 requires that abstract model app is in INSTALLED_APPS
46-
if StrictVersion("1.8") <= StrictVersion(django.__version__) < StrictVersion("1.9"):
46+
if Version("1.8") <= Version(django.__version__) < Version("1.9"):
4747
INSTALLED_APPS.append("django_lifecycle")
4848

4949

0 commit comments

Comments
 (0)