Merge pull request #161 from rsinger86/revert/use-copy-instead-of-deepcopy

Revert to copying model state instead of deepcopying it

Author: EnriqueSoria

django_lifecycle/model_state.py

@@ -1,6 +1,4 @@
 from __future__ import annotations
-
-from copy import deepcopy
 from typing import Any
 from typing import Dict
 from typing import TYPE_CHECKING
@@ -18,7 +16,7 @@ def __init__(self, initial_state: Dict[str, Any]):
 
     @classmethod
     def from_instance(cls, instance: "LifecycleModelMixin") -> ModelState:
-        state = deepcopy(instance.__dict__)
+        state = instance.__dict__.copy()
 
         for watched_related_field in instance._watched_fk_model_fields():
             state[watched_related_field] = get_value(instance, watched_related_field)

tests/testapp/tests/test_mixin.py

@@ -77,15 +77,6 @@ def test_initial_value_if_field_has_changed(self):
         user_account.username = "Josephine"
         self.assertEqual(user_account.initial_value("username"), "Joe")
 
-    def test_initial_value_if_mutable_field_has_changed(self):
-        data = self.stub_data
-        UserAccount.objects.create(**data)
-        user_account = UserAccount.objects.get()
-        self.assertFalse(user_account.has_changed("configurations"))
-        user_account.configurations["notifications"] = True
-        self.assertTrue(user_account.has_changed("configurations"))
-        self.assertEqual(user_account.initial_value("configurations"), {})
-
     def test_initial_value_if_field_has_not_changed(self):
         data = self.stub_data
         data["username"] = "Joe"
@@ -213,7 +204,6 @@ def test_has_changed_when_refreshed_from_db(self):
         self.assertTrue(user_account.has_changed("username"),
                         'The initial state should get updated after refreshing the object from db')
 
-
     def test_has_changed_is_true_if_fk_related_model_field_has_changed(self):
         org = Organization.objects.create(name="Dunder Mifflin")
         UserAccount.objects.create(**self.stub_data, organization=org)