feat(federate): add bitcoin utils from rskj to powpeg node

Author: apancorb

src/test/java/co/rsk/federate/bitcoin/BitcoinTestUtils.java

@@ -1,10 +1,16 @@
 package co.rsk.federate.bitcoin;
 
+import static co.rsk.bitcoinj.script.ScriptBuilder.createP2SHOutputScript;
+import static co.rsk.peg.bitcoin.BitcoinUtils.*;
+
 import co.rsk.bitcoinj.core.Address;
 import co.rsk.bitcoinj.core.BtcECKey;
+import co.rsk.bitcoinj.core.BtcTransaction;
 import co.rsk.bitcoinj.core.Coin;
 import co.rsk.bitcoinj.core.NetworkParameters;
 import co.rsk.bitcoinj.core.Sha256Hash;
+import co.rsk.bitcoinj.core.TransactionInput;
+import co.rsk.bitcoinj.crypto.TransactionSignature;
 import co.rsk.bitcoinj.script.Script;
 import co.rsk.bitcoinj.script.ScriptBuilder;
 import java.nio.charset.StandardCharsets;
@@ -66,4 +72,31 @@ public static Address createP2SHMultisigAddress(NetworkParameters networkParamet
         Script outputScript = ScriptBuilder.createP2SHOutputScript(redeemScript);
         return Address.fromP2SHScript(networkParameters, outputScript);
     }
+
+    public static void signTransactionInputFromP2shMultiSig(BtcTransaction transaction, int inputIndex, List<BtcECKey> keys) {
+        if (transaction.getWitness(inputIndex).getPushCount() == 0) {
+            signLegacyTransactionInputFromP2shMultiSig(transaction, inputIndex, keys);
+        }
+    }
+
+    private static void signLegacyTransactionInputFromP2shMultiSig(BtcTransaction transaction, int inputIndex, List<BtcECKey> keys) {
+        TransactionInput input = transaction.getInput(inputIndex);
+
+        Script inputRedeemScript = extractRedeemScriptFromInput(input)
+            .orElseThrow(() -> new IllegalArgumentException("Cannot sign inputs that are not from a p2sh multisig"));
+
+        Script outputScript = createP2SHOutputScript(inputRedeemScript);
+        Sha256Hash sigHash = transaction.hashForSignature(inputIndex, inputRedeemScript, BtcTransaction.SigHash.ALL, false);
+        Script inputScriptSig = input.getScriptSig();
+
+        for (BtcECKey key : keys) {
+            BtcECKey.ECDSASignature sig = key.sign(sigHash);
+            TransactionSignature txSig = new TransactionSignature(sig, BtcTransaction.SigHash.ALL, false);
+            byte[] txSigEncoded = txSig.encodeToBitcoin();
+
+            int keyIndex = inputScriptSig.getSigInsertionIndex(sigHash, key);
+            inputScriptSig = outputScript.getScriptSigWithSignature(inputScriptSig, txSigEncoded, keyIndex);
+            input.setScriptSig(inputScriptSig);
+        }
+    }
 }

src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

@@ -33,7 +33,7 @@
 import co.rsk.bitcoinj.script.Script;
 import co.rsk.bitcoinj.script.ScriptBuilder;
 import co.rsk.bitcoinj.script.ScriptChunk;
-import co.rsk.peg.bitcoin.BitcoinTestUtils;
+import co.rsk.federate.bitcoin.BitcoinTestUtils;
 import co.rsk.peg.bitcoin.BitcoinUtils;
 import co.rsk.peg.bitcoin.FlyoverRedeemScriptBuilderImpl;
 import co.rsk.peg.constants.BridgeConstants;
@@ -771,7 +771,8 @@ void onBestBlock_whenOnlySvpSpendTxWaitingForSignaturesIsAvailable_shouldAddSign
     @Test
     void onBestBlock_whenSvpSpendTxWaitingForSignaturesIsAvailableWithSignatureFromAnotherFederationMember_shouldSendAddSignature() throws Exception {
         // Arrange
-        Federation proposedFederation = TestUtils.createFederation(params, 9);
+        List<BtcECKey> federationPrivateKeys = TestUtils.getFederationPrivateKeys(9);
+        Federation proposedFederation = TestUtils.createFederation(bridgeConstants.getBtcParams(), federationPrivateKeys);
         FederationMember federationMember = proposedFederation.getMembers().get(0);
         Script scriptSig = proposedFederation.getP2SHScript().createEmptyInputScript(null, proposedFederation.getRedeemScript());
 
@@ -787,7 +788,7 @@ void onBestBlock_whenSvpSpendTxWaitingForSignaturesIsAvailableWithSignatureFromA
             BitcoinTestUtils.signTransactionInputFromP2shMultiSig(
                 svpSpendTx,
                 inputs.indexOf(input),
-                List.of(new BtcECKey())
+                List.of(federationPrivateKeys.get(0))
             );
         }
 
@@ -879,7 +880,7 @@ void onBestBlock_whenSvpSpendTxWaitingForSignaturesIsAvailableWithSignatureFromA
         BitcoinUtils.removeSignaturesFromTransactionWithP2shMultiSigInputs(svpSpendTx);
         assertEquals(svpSpendTxHashBeforeSigning, svpSpendTx.getHash());
         verify(releaseCreationInformationGetter).getTxInfoToSign(
-            any(),
+            anyInt(),
             eq(svpSpendCreationRskTxHash),
             eq(svpSpendTx));