Merge pull request #481 from rsksmart/skip_old_unprocessable_pegout

Skip old unprocessable pegout when processing pegouts

Author: marcos-iov

src/main/java/co/rsk/federate/btcreleaseclient/BtcReleaseClient.java

@@ -318,6 +318,10 @@ protected void processReleases(Set<Map.Entry<Keccak256, BtcTransaction>> pegouts
                 Keccak256 pegoutCreationRskTxHash = pegout.getKey();
                 BtcTransaction pegoutBtcTx = pegout.getValue();
 
+                if (pegoutIsUnprocessable(pegoutCreationRskTxHash)) {
+                    continue;
+                }
+
                 tryGetReleaseInformation(version, pegoutCreationRskTxHash, pegoutBtcTx)
                     .ifPresent(pegoutsReadyToSign::add);
             }
@@ -335,6 +339,17 @@ protected void processReleases(Set<Map.Entry<Keccak256, BtcTransaction>> pegouts
         logger.trace("[processReleases] Finished processing pegouts");
     }
 
+    private boolean pegoutIsUnprocessable(Keccak256 pegoutCreationRskTxHash) {
+        boolean networkIsTestnet = bridgeConstants.getBtcParams().getId()
+            .equals(co.rsk.bitcoinj.core.NetworkParameters.ID_TESTNET);
+        // there is a very old pegout that remains unprocessed.
+        // since the federation changed from that time to now, it is unprocessable,
+        // so we should not keep trying processing it
+        Keccak256 unprocessablePegoutRskTxCreationHash =
+            new Keccak256("86c6739feeb9279d8c7cd85bc6732cb818c3a9d54b55a070adfe1d31ba10f4e5");
+        return networkIsTestnet && pegoutCreationRskTxHash.equals(unprocessablePegoutRskTxCreationHash);
+    }
+
     protected Optional<ReleaseCreationInformation> tryGetReleaseInformation(
         int signerVersion,
         Keccak256 pegoutCreationRskTxHash,