Skip to content
This repository was archived by the owner on May 19, 2023. It is now read-only.

Commit 4354575

Browse files
authored
fix(header): appends login component to items end (#189)
1 parent 45833bc commit 4354575

File tree

2 files changed

+26
-30
lines changed

2 files changed

+26
-30
lines changed

src/components/organisms/Header/HeaderDesktop.tsx

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ const useStyles = makeStyles((theme: Theme) => ({
3636
// this height needs to be equal to the marginTop of PageTemplate
3737
height: theme.spacing(globalConstants.headerHeight),
3838
},
39+
itemsEnd: {
40+
alignItems: 'center',
41+
},
3942
}))
4043

4144
const HeaderDesktop: FC<HeaderProps> = ({
@@ -57,8 +60,7 @@ const HeaderDesktop: FC<HeaderProps> = ({
5760
</Grid>
5861
<Grid
5962
item
60-
xs={6}
61-
xl={8}
63+
xs={7}
6264
container
6365
justify="flex-start"
6466
>
@@ -82,32 +84,24 @@ const HeaderDesktop: FC<HeaderProps> = ({
8284
</Grid>
8385
<Grid
8486
item
85-
xs={3}
86-
xl={2}
87+
xs={4}
8788
container
8889
justify="flex-end"
8990
alignContent="center"
9091
>
9192
{
9293
!!itemsEnd?.length
9394
&& itemsEnd.map(({ icon, ...rest }: ActionHeaderItemProps) => (
94-
<ListItemIcon key={icon.key} {...rest}>
95+
<ListItemIcon
96+
key={icon.key}
97+
className={classes.itemsEnd}
98+
{...rest}
99+
>
95100
{icon}
96101
</ListItemIcon>
97102
))
98103
}
99-
</Grid>
100-
<Grid
101-
item
102-
container
103-
xs={2}
104-
xl={1}
105-
justify="flex-end"
106-
alignContent="center"
107-
>
108-
<div>
109-
<Login />
110-
</div>
104+
<Login />
111105
</Grid>
112106
</Grid>
113107
</Toolbar>

src/components/organisms/Header/HeaderMobile.tsx

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ const useStyles = makeStyles((theme: Theme) => createStyles({
6060
mobileNavLinkActive: {
6161
color: `${colors.primary} !important`,
6262
},
63+
itemsEnd: {
64+
alignItems: 'center',
65+
},
6366
}))
6467

6568
const HeaderMobile: FC<HeaderProps> = ({
@@ -111,26 +114,25 @@ const HeaderMobile: FC<HeaderProps> = ({
111114
</Grid>
112115
<Grid
113116
item
114-
md={6}
115-
sm={5}
116-
xs={4}
117+
xs={8}
117118
container
118119
justify="flex-end"
119120
alignContent="center"
120121
>
121122
{
122123
!!itemsEnd?.length
123-
&& itemsEnd.map(({ icon, ...rest }: ActionHeaderItemProps) => (
124-
<ListItemIcon key={icon.key} {...rest}>
125-
{icon}
126-
</ListItemIcon>
127-
))
124+
&& itemsEnd
125+
.map(({ icon, ...rest }: ActionHeaderItemProps) => (
126+
<ListItemIcon
127+
key={icon.key}
128+
className={classes.itemsEnd}
129+
{...rest}
130+
>
131+
{icon}
132+
</ListItemIcon>
133+
))
128134
}
129-
</Grid>
130-
<Grid item md={2} sm={3} xs={4} container justify="flex-end" alignContent="center">
131-
<div>
132-
<Login />
133-
</div>
135+
<Login />
134136
</Grid>
135137
</Grid>
136138
)}

0 commit comments

Comments
 (0)