Added more tests for select form field

Author: Said Shah

src/atoms/forms/select.tsx

@@ -50,6 +50,7 @@ const Select: React.FC<SelectProps> = (props: SelectProps) => {
     return (
         <div className={classNames.join(" ")}>
             <select
+                id={props.id}
                 onChange={handleChange}
                 value={props.value}
                 name={props.name}>

src/molecules/form-fields/select-form-field.test.tsx

@@ -1,5 +1,5 @@
 import React from "react";
-import { render } from "@testing-library/react";
+import { render, fireEvent } from "@testing-library/react";
 import {
     SelectFormField,
     InvalidSelectFormValueClass,
@@ -142,4 +142,30 @@ describe("SelectFormField", () => {
         // Assert
         expect(htmlLabelTag[0].textContent).toContain(requiredText);
     });
+
+    test("when onChange set, calls handler upon change", () => {
+        // Arrange
+        const label = faker.random.word();
+        let isChecked = false;
+        const handleChange = () => (isChecked = true);
+        const selectLabel = faker.random.word();
+        const selectValue = faker.random.word();
+
+        // Act
+        const { getByLabelText, container } = render(
+            <SelectFormField
+                onChange={handleChange}
+                label={label}
+                id={label}
+                values={[{ value: selectValue, label: selectLabel }]}
+            />
+        );
+
+        fireEvent.change(getByLabelText(label), {
+            target: { value: faker.random.word() },
+        });
+
+        // Assert
+        expect(isChecked).toBeTrue();
+    });
 });

src/molecules/form-fields/select-form-field.tsx

@@ -19,7 +19,6 @@ export const InvalidSelectFormValueClass = "-invalid";
 export interface SelectFormFieldProps {
     errorMessage?: string;
     errorMessages?: string[];
-    fieldId?: string;
     id: string;
     isValid?: boolean;
     name?: string;
@@ -41,7 +40,6 @@ const SelectFormField: React.FC<SelectFormFieldProps> = (
     const {
         errorMessage,
         errorMessages,
-        id,
         isValid,
         name,
         label,
@@ -51,13 +49,13 @@ const SelectFormField: React.FC<SelectFormFieldProps> = (
     } = props;
 
     const cssIsValid = isValid ? "" : InvalidSelectFormValueClass;
-    const fieldId = props.fieldId ?? uuid.v4();
+    const id = props.id ?? uuid.v4();
     const hasErrorMessage = StringUtils.hasValue(errorMessage);
     const hasErrors = CollectionUtils.hasValues(errorMessages);
 
     return (
         <div className={`${COMPONENT_CLASS} ${cssIsValid}`}>
-            <label htmlFor={fieldId}>
+            <label htmlFor={id}>
                 {label}
                 {required ? "*" : ""}
             </label>