Merge pull request #78 from DevFactory/release/dead-stores-should-be-removed-fix-1

Code quality fix - Dead stores should be removed.

Author: stevegury

src/main/java/io/reactivesocket/exceptions/Exceptions.java

@@ -34,7 +34,7 @@ public static Throwable from(Frame frame) {
             message = new String(byteBuffer.array(), UTF_8);
         }
 
-        Throwable ex = null;
+        Throwable ex;
         switch (errorCode) {
             case APPLICATION_ERROR:
                 ex = new ApplicationException(message);

src/main/java/io/reactivesocket/internal/Requester.java

@@ -947,7 +947,7 @@ public void onNext(Frame frame) {
             }
 
             public void onError(Throwable t) {
-                Collection<UnicastSubject<Frame>> subjects = null;
+                Collection<UnicastSubject<Frame>> subjects;
                 synchronized (Requester.this) {
                     subjects = streamInputMap.values();
                 }
@@ -958,7 +958,7 @@ public void onError(Throwable t) {
             }
 
             public void onComplete() {
-                Collection<UnicastSubject<Frame>> subjects = null;
+                Collection<UnicastSubject<Frame>> subjects;
                 synchronized (Requester.this) {
                     subjects = streamInputMap.values();
                 }

src/main/java/io/reactivesocket/internal/Responder.java

@@ -257,7 +257,7 @@ public void onNext(Frame requestFrame) {
 							responsePublisher = handleMetadataPush(
                                 requestFrame, requestHandler);
 						} else if (requestFrame.getType() == FrameType.CANCEL) {
-							Subscription s = null;
+							Subscription s;
 							synchronized (Responder.this) {
 								s = cancellationSubscriptions.get(requestFrame.getStreamId());
 							}
@@ -266,7 +266,7 @@ public void onNext(Frame requestFrame) {
 							}
 							return;
 						} else if (requestFrame.getType() == FrameType.REQUEST_N) {
-							SubscriptionArbiter inFlightSubscription = null;
+							SubscriptionArbiter inFlightSubscription;
 							synchronized (Responder.this) {
 								inFlightSubscription = inFlight.get(requestFrame.getStreamId());
 							}
@@ -697,7 +697,7 @@ private Publisher<Frame> handleRequestChannel(Frame requestFrame,
 			Int2ObjectHashMap<Subscription> cancellationSubscriptions,
 			Int2ObjectHashMap<SubscriptionArbiter> inFlight) {
 
-		UnicastSubject<Payload> channelSubject = null;
+		UnicastSubject<Payload> channelSubject;
 		synchronized(Responder.this) {
 			channelSubject = channels.get(requestFrame.getStreamId());
 		}
@@ -873,7 +873,7 @@ public void addTransportRequest(long n) {
 		}
 
 		private void tryRequest() {
-			long toRequest = 0;
+			long toRequest;
 			synchronized(this) {
 				if(applicationProducer == null) {
 					return;

src/main/java/io/reactivesocket/internal/rx/CompositeDisposable.java

@@ -47,7 +47,7 @@ public void clear() {
 
 	@Override
 	public void dispose() {
-		Disposable[] cs = null;
+		Disposable[] cs;
 		synchronized (this) {
 			disposed = true;
 			cs = resources.toArray(new Disposable[] {});

src/main/java/io/reactivesocket/lease/FairLeaseGovernor.java

@@ -68,7 +68,7 @@ public synchronized void unregister(Responder responder) {
 
     @Override
     public synchronized boolean accept(Responder responder, Frame frame) {
-        boolean valid = false;
+        boolean valid;
         final Integer remainingTickets = responders.get(responder);
         return remainingTickets == null || remainingTickets > 0;
     }