refactored ReactiveSocketImpl to DefaultReactiveSocket

Author: robertroeser

src/main/java/io/reactivesocket/ReactiveSocketImpl.java renamed to src/main/java/io/reactivesocket/DefaultReactiveSocket.java

@@ -37,7 +37,7 @@
 /**
  * An implementation of {@link ReactiveSocket}
  */
-public class ReactiveSocketImpl implements ReactiveSocket {
+public class DefaultReactiveSocket implements ReactiveSocket {
     private static final RequestHandler EMPTY_HANDLER = new RequestHandler.Builder().build();
 
     private static final Consumer<Throwable> DEFAULT_ERROR_STREAM = t -> {
@@ -56,7 +56,7 @@ public class ReactiveSocketImpl implements ReactiveSocket {
     private final ConnectionSetupHandler responderConnectionHandler;
     private final LeaseGovernor leaseGovernor;
 
-    private ReactiveSocketImpl(
+    private DefaultReactiveSocket(
         DuplexConnection connection,
         boolean isServer,
         ConnectionSetupPayload serverRequestorSetupPayload,
@@ -112,7 +112,7 @@ public static ReactiveSocket fromClientConnection(
         }
         final RequestHandler h = handler != null ? handler : EMPTY_HANDLER;
         Consumer<Throwable> es = errorStream != null ? errorStream : DEFAULT_ERROR_STREAM;
-        return new ReactiveSocketImpl(connection, false, setup, h, null, NULL_LEASE_GOVERNOR, es);
+        return new DefaultReactiveSocket(connection, false, setup, h, null, NULL_LEASE_GOVERNOR, es);
     }
 
     /**
@@ -172,7 +172,7 @@ public static ReactiveSocket fromServerConnection(
         LeaseGovernor leaseGovernor,
         Consumer<Throwable> errorConsumer
     ) {
-        return new ReactiveSocketImpl(connection, true, null, null, connectionHandler,
+        return new DefaultReactiveSocket(connection, true, null, null, connectionHandler,
             leaseGovernor, errorConsumer);
     }
 

src/perf/java/io/reactivesocket/ReactiveSocketPerf.java

@@ -132,10 +132,10 @@ public Publisher<Void> handleMetadataPush(Payload payload)
 			}
 		};
 
-		final static ReactiveSocket serverSocket = ReactiveSocketImpl.fromServerConnection(serverConnection, setupFrame -> handler);
+		final static ReactiveSocket serverSocket = DefaultReactiveSocket.fromServerConnection(serverConnection, setupFrame -> handler);
 
 		final static ReactiveSocket client =
-			ReactiveSocketImpl.fromClientConnection(
+			DefaultReactiveSocket.fromClientConnection(
 				clientConnection, ConnectionSetupPayload.create("UTF-8", "UTF-8", ConnectionSetupPayload.NO_FLAGS), t -> {});
 
 		static {

src/test/java/io/reactivesocket/LeaseTest.java

@@ -80,7 +80,7 @@ public void setup() throws InterruptedException {
         clientConnection.connectToServerConnection(serverConnection);
         leaseGovernor = new TestingLeaseGovernor();
 
-        socketServer = ReactiveSocketImpl.fromServerConnection(
+        socketServer = DefaultReactiveSocket.fromServerConnection(
             serverConnection, setup -> new RequestHandler() {
 
                 @Override
@@ -127,7 +127,7 @@ public Publisher<Void> handleMetadataPush(Payload payload) {
                 }
             }, leaseGovernor, t -> {});
 
-        socketClient = ReactiveSocketImpl.fromClientConnection(
+        socketClient = DefaultReactiveSocket.fromClientConnection(
             clientConnection,
             ConnectionSetupPayload.create("UTF-8", "UTF-8", HONOR_LEASE)
         );

src/test/java/io/reactivesocket/ReactiveSocketTest.java

@@ -64,7 +64,7 @@ public void setup() {
 		fireAndForgetOrMetadataPush = new CountDownLatch(1);
 		lastServerErrorCountDown = new CountDownLatch(1);
 
-		socketServer = ReactiveSocketImpl.fromServerConnection(serverConnection, setup -> new RequestHandler() {
+		socketServer = DefaultReactiveSocket.fromServerConnection(serverConnection, setup -> new RequestHandler() {
 
 			@Override
 			public Publisher<Payload> handleRequestResponse(Payload payload) {
@@ -205,7 +205,7 @@ private void startSockets(int setupFlag, RequestHandler handler) throws Interrup
 		} else if (setupFlag == HONOR_LEASE) {
 			System.out.println("Reactivesocket configured with: HONOR_LEASE");
 		}
-		socketClient = ReactiveSocketImpl.fromClientConnection(
+		socketClient = DefaultReactiveSocket.fromClientConnection(
 			clientConnection,
 			ConnectionSetupPayload.create("UTF-8", "UTF-8", setupFlag),
 			handler, 
@@ -264,7 +264,7 @@ public void testRequestResponse(int setupFlag) throws InterruptedException {
 
 	@Test(timeout=2000, expected=IllegalStateException.class)
 	public void testRequestResponsePremature() throws InterruptedException {
-		socketClient = ReactiveSocketImpl.fromClientConnection(
+		socketClient = DefaultReactiveSocket.fromClientConnection(
 				clientConnection,
 				ConnectionSetupPayload.create("UTF-8", "UTF-8", NO_FLAGS),
 				err -> err.printStackTrace()

src/test/java/io/reactivesocket/TestFlowControlRequestN.java

@@ -315,7 +315,7 @@ public static void setup() throws InterruptedException {
 		clientConnection.connectToServerConnection(serverConnection, false);
 
 
-		socketServer = ReactiveSocketImpl.fromServerConnection(serverConnection, setup -> new RequestHandler() {
+		socketServer = DefaultReactiveSocket.fromServerConnection(serverConnection, setup -> new RequestHandler() {
 
 			@Override
 			public Publisher<Payload> handleRequestStream(Payload payload) {
@@ -440,7 +440,7 @@ public Publisher<Void> handleMetadataPush(Payload payload)
 			}
 		}, LeaseGovernor.UNLIMITED_LEASE_GOVERNOR, Throwable::printStackTrace);
 
-		socketClient = ReactiveSocketImpl.fromClientConnection(
+		socketClient = DefaultReactiveSocket.fromClientConnection(
             clientConnection,
             ConnectionSetupPayload.create("UTF-8", "UTF-8", NO_FLAGS),
             Throwable::printStackTrace

src/test/java/io/reactivesocket/TestTransportRequestN.java

@@ -172,7 +172,7 @@ public void setup(TestConnectionWithControlledRequestN clientConnection, TestCon
 		clientConnection.connectToServerConnection(serverConnection, false);
 		lastServerErrorCountDown = new CountDownLatch(1);
 
-		socketServer = ReactiveSocketImpl.fromServerConnection(serverConnection, setup -> new RequestHandler() {
+		socketServer = DefaultReactiveSocket.fromServerConnection(serverConnection, setup -> new RequestHandler() {
 
 			@Override
 			public Publisher<Payload> handleRequestResponse(Payload payload) {
@@ -218,7 +218,7 @@ public Publisher<Void> handleMetadataPush(Payload payload) {
 			lastServerErrorCountDown.countDown();
 		});
 
-		socketClient = ReactiveSocketImpl.fromClientConnection(
+		socketClient = DefaultReactiveSocket.fromClientConnection(
 				clientConnection,
 				ConnectionSetupPayload.create("UTF-8", "UTF-8", ConnectionSetupPayload.NO_FLAGS),
 				err -> err.printStackTrace());