Skip to content

Commit 80d41e2

Browse files
committed
test: consume actual rsocket code in browser tck test
Signed-off-by: Kevin Viglucci <[email protected]>
1 parent 009e52f commit 80d41e2

File tree

8 files changed

+46
-33
lines changed

8 files changed

+46
-33
lines changed

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222
"clean": "lerna run clean && rimraf -rf ./coverage",
2323
"pub": "lerna publish",
2424
"pretest": "yarn clean",
25-
"test": "lerna run test",
25+
"test": "lerna run test --ignore=@rsocket/browser-tck",
26+
"pretest-rsocket-browser-tck": "lerna bootstrap && lerna run build --ignore=@rsocket/browser-tck",
27+
"test-rsocket-browser-tck": "lerna run test --scope=@rsocket/browser-tck",
2628
"lint": "eslint --ext js,ts .",
2729
"lint:fix": "npm run lint -- --fix"
2830
},

packages/rsocket-browser-tck/karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module.exports = function (config) {
1111
"**/*.ts": ["karma-typescript"],
1212
},
1313

14-
reporters: ["dots", "karma-typescript"],
14+
reporters: ["mocha", "karma-typescript"],
1515

1616
browsers: ["ChromeHeadless"],
1717

packages/rsocket-browser-tck/package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,18 @@
66
"test": "karma start"
77
},
88
"dependencies": {
9+
"@rsocket/composite-metadata": "^1.0.0-alpha.1",
10+
"@rsocket/core": "^1.0.0-alpha.1",
11+
"@rsocket/transport-websocket-client": "^1.0.0-alpha.1",
12+
"@rsocket/transport-websocket-server": "^1.0.0-alpha.1",
913
"@types/expect.js": "^0.3.29",
1014
"@types/mocha": "^5.2.5",
1115
"expect.js": "^0.3.1",
1216
"karma": "^6.1.0",
1317
"karma-chrome-launcher": "^3.1.0",
1418
"karma-cli": "^2.0.0",
1519
"karma-mocha": "^1.3.0",
20+
"karma-mocha-reporter": "^2.0.0",
1621
"karma-typescript": "5.5.3",
1722
"mocha": "^6.2.0",
1823
"typescript": "~4.5.4"
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
import {
2+
// OnExtensionSubscriber,
3+
// OnNextSubscriber,
4+
// OnTerminalSubscriber,
5+
// Payload,
6+
RSocketConnector,
7+
} from "@rsocket/core";
8+
import { WebsocketClientTransport } from "@rsocket/transport-websocket-client";
9+
10+
describe("WebsocketClientTransport", () => {
11+
it("sanity check", () => {
12+
expect(1 + 2).to.be(3);
13+
});
14+
15+
// TODO: test that actually connects and exercises WS and Buffer impl
16+
// it("can be used in a browser environment", async () => {
17+
// const connector = new RSocketConnector({
18+
// transport: new WebsocketClientTransport({
19+
// url: "ws://localhost:9090",
20+
// wsCreator: (url) => new WebSocket(url) as any,
21+
// }),
22+
// });
23+
//
24+
// await connector.connect();
25+
// });
26+
});

packages/rsocket-browser-tck/src/hello-service.interface.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/rsocket-browser-tck/src/hello.component.spec.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/rsocket-browser-tck/src/hello.component.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

yarn.lock

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2336,7 +2336,7 @@ caseless@~0.12.0:
23362336
resolved "https://registry.npmjs.org/caseless/-/caseless-0.12.0.tgz"
23372337
integrity sha1-G2gcIf+EAzyCZUMJBolCDRhxUdw=
23382338

2339-
chalk@^2.0.0, chalk@^2.0.1:
2339+
chalk@^2.0.0, chalk@^2.0.1, chalk@^2.1.0:
23402340
version "2.4.2"
23412341
resolved "https://registry.npmjs.org/chalk/-/chalk-2.4.2.tgz"
23422342
integrity sha512-Mti+f9lpJNcwF4tWV8/OrTTtF1gZi+f8FqlyAdouralcFWFQWF2+NgCHShjkCb+IFBLq9buZwE1xckQU4peSuQ==
@@ -5133,6 +5133,15 @@ karma-cli@^2.0.0:
51335133
dependencies:
51345134
resolve "^1.3.3"
51355135

5136+
karma-mocha-reporter@^2.0.0:
5137+
version "2.2.5"
5138+
resolved "https://registry.yarnpkg.com/karma-mocha-reporter/-/karma-mocha-reporter-2.2.5.tgz#15120095e8ed819186e47a0b012f3cd741895560"
5139+
integrity sha1-FRIAlejtgZGG5HoLAS8810GJVWA=
5140+
dependencies:
5141+
chalk "^2.1.0"
5142+
log-symbols "^2.1.0"
5143+
strip-ansi "^4.0.0"
5144+
51365145
karma-mocha@^1.3.0:
51375146
version "1.3.0"
51385147
resolved "https://registry.yarnpkg.com/karma-mocha/-/karma-mocha-1.3.0.tgz#eeaac7ffc0e201eb63c467440d2b69c7cf3778bf"
@@ -5392,7 +5401,7 @@ lodash@^4.17.15, lodash@^4.17.19, lodash@^4.17.21, lodash@^4.7.0:
53925401
resolved "https://registry.npmjs.org/lodash/-/lodash-4.17.21.tgz"
53935402
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
53945403

5395-
5404+
[email protected], log-symbols@^2.1.0:
53965405
version "2.2.0"
53975406
resolved "https://registry.yarnpkg.com/log-symbols/-/log-symbols-2.2.0.tgz#5740e1c5d6f0dfda4ad9323b5332107ef6b4c40a"
53985407
integrity sha512-VeIAFslyIerEJLXHziedo2basKbMKtTw3vfn5IzG0XTjhAVEJyNHnL2p7vc+wBDSdQuUpNw3M2u6xb9QsAY5Eg==

0 commit comments

Comments
 (0)