Skip to content

Commit 4a7bedb

Browse files
author
olme04
committed
minor logging changes
1 parent c1a8d97 commit 4a7bedb

File tree

13 files changed

+34
-46
lines changed

13 files changed

+34
-46
lines changed

buildSrc/src/main/kotlin/TestOptIn.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ fun LanguageSettingsBuilder.optInForTest() {
1414
optIn("io.rsocket.kotlin.TransportApi")
1515
optIn("io.rsocket.kotlin.ExperimentalMetadataApi")
1616
optIn("io.rsocket.kotlin.ExperimentalStreamsApi")
17-
optIn("io.rsocket.kotlin.RSocketLoggingApi")
17+
optIn("io.rsocket.kotlin.logging.ExperimentalLoggingApi")
1818
}

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/Annotations.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,4 @@ public annotation class ExperimentalMetadataApi
3838
)
3939
public annotation class ExperimentalStreamsApi
4040

41-
@Retention(value = AnnotationRetention.BINARY)
42-
@RequiresOptIn(
43-
level = RequiresOptIn.Level.WARNING,
44-
message = "This is mostly internal API used for logging. This API can change in future in non backwards-compatible manner."
45-
)
46-
public annotation class RSocketLoggingApi
47-
4841

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/internal/LoggingConnection.kt renamed to rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/connect/LoggingConnection.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
* limitations under the License.
1515
*/
1616

17-
@file:OptIn(TransportApi::class, RSocketLoggingApi::class)
17+
@file:OptIn(TransportApi::class, ExperimentalLoggingApi::class)
1818

19-
package io.rsocket.kotlin.internal
19+
package io.rsocket.kotlin.connect
2020

2121
import io.ktor.utils.io.core.*
2222
import io.rsocket.kotlin.*

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/connect/RSocketConnector.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
@file:OptIn(TransportApi::class, RSocketLoggingApi::class)
17+
@file:OptIn(TransportApi::class, ExperimentalLoggingApi::class)
1818

1919
package io.rsocket.kotlin.connect
2020

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/connect/RSocketPeerProvider.kt

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
package io.rsocket.kotlin.connect
22

3-
import io.rsocket.kotlin.*
43
import io.rsocket.kotlin.logging.*
54

65
public sealed interface RSocketPeerProvider {
7-
@RSocketLoggingApi
6+
@ExperimentalLoggingApi
87
public val loggerFactory: LoggerFactory
98
}
109

1110
//TODO: naming
1211
public sealed interface RSocketPeerProviderBuilder {
13-
@RSocketLoggingApi
12+
@ExperimentalLoggingApi
1413
public fun loggerFactory(factory: LoggerFactory)
1514

1615
public fun beforePeerConfiguration(configurator: RSocketConnectConfigurator)
@@ -23,15 +22,15 @@ public sealed interface RSocketPeerProviderBuilder {
2322
}
2423

2524
internal abstract class RSocketPeerBuilderImpl : RSocketPeerProviderBuilder {
26-
@RSocketLoggingApi
25+
@ExperimentalLoggingApi
2726
protected var loggerFactory: LoggerFactory = DefaultLoggerFactory
2827
private set
2928

3029
protected val beforeConfigurators = mutableListOf<RSocketConnectConfigurator>()
3130
protected val afterConfigurators = mutableListOf<RSocketConnectConfigurator>()
3231
protected var defaultConfigurator: RSocketConnectConfigurator? = null
3332

34-
@RSocketLoggingApi
33+
@ExperimentalLoggingApi
3534
final override fun loggerFactory(factory: LoggerFactory) {
3635
loggerFactory = factory
3736
}

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/connect/RSocketServer.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,14 @@
1414
* limitations under the License.
1515
*/
1616

17-
@file:OptIn(TransportApi::class, RSocketLoggingApi::class)
17+
@file:OptIn(TransportApi::class, ExperimentalLoggingApi::class)
1818

1919
package io.rsocket.kotlin.connect
2020

2121
import io.rsocket.kotlin.*
2222
import io.rsocket.kotlin.core.*
2323
import io.rsocket.kotlin.frame.*
2424
import io.rsocket.kotlin.frame.io.*
25-
import io.rsocket.kotlin.internal.*
2625
import io.rsocket.kotlin.logging.*
2726
import io.rsocket.kotlin.transport.*
2827
import kotlinx.coroutines.*
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package io.rsocket.kotlin.logging
2+
3+
@Retention(value = AnnotationRetention.BINARY)
4+
@RequiresOptIn(
5+
level = RequiresOptIn.Level.WARNING,
6+
message = "This is mostly internal API used for logging. This API can change in future in non backwards-compatible manner."
7+
)
8+
public annotation class ExperimentalLoggingApi

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/logging/Logging.kt

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,27 +16,25 @@
1616

1717
package io.rsocket.kotlin.logging
1818

19-
import io.rsocket.kotlin.*
20-
21-
@RSocketLoggingApi
19+
@ExperimentalLoggingApi
2220
public enum class LoggingLevel { TRACE, DEBUG, INFO, WARN, ERROR }
2321

24-
@RSocketLoggingApi
22+
@ExperimentalLoggingApi
2523
public fun interface LoggerFactory {
2624
public fun logger(tag: String): Logger
2725
}
2826

29-
@RSocketLoggingApi
27+
@ExperimentalLoggingApi
3028
internal expect val DefaultLoggerFactory: LoggerFactory
3129

32-
@RSocketLoggingApi
30+
@ExperimentalLoggingApi
3331
public interface Logger {
3432
public val tag: String
3533
public fun isLoggable(level: LoggingLevel): Boolean
3634
public fun rawLog(level: LoggingLevel, throwable: Throwable?, message: Any?)
3735
}
3836

39-
@RSocketLoggingApi
37+
@ExperimentalLoggingApi
4038
public inline fun Logger.log(level: LoggingLevel, throwable: Throwable? = null, message: () -> Any?) {
4139
if (!isLoggable(level)) return
4240

@@ -48,27 +46,27 @@ public inline fun Logger.log(level: LoggingLevel, throwable: Throwable? = null,
4846
rawLog(level, throwable, msg)
4947
}
5048

51-
@RSocketLoggingApi
49+
@ExperimentalLoggingApi
5250
public inline fun Logger.trace(throwable: Throwable? = null, message: () -> Any?) {
5351
log(LoggingLevel.TRACE, throwable, message)
5452
}
5553

56-
@RSocketLoggingApi
54+
@ExperimentalLoggingApi
5755
public inline fun Logger.debug(throwable: Throwable? = null, message: () -> Any?) {
5856
log(LoggingLevel.DEBUG, throwable, message)
5957
}
6058

61-
@RSocketLoggingApi
59+
@ExperimentalLoggingApi
6260
public inline fun Logger.info(throwable: Throwable? = null, message: () -> Any?) {
6361
log(LoggingLevel.INFO, throwable, message)
6462
}
6563

66-
@RSocketLoggingApi
64+
@ExperimentalLoggingApi
6765
public inline fun Logger.warn(throwable: Throwable? = null, message: () -> Any?) {
6866
log(LoggingLevel.WARN, throwable, message)
6967
}
7068

71-
@RSocketLoggingApi
69+
@ExperimentalLoggingApi
7270
public inline fun Logger.error(throwable: Throwable? = null, message: () -> Any?) {
7371
log(LoggingLevel.ERROR, throwable, message)
7472
}

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/logging/NoopLogger.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,10 @@
1616

1717
package io.rsocket.kotlin.logging
1818

19-
import io.rsocket.kotlin.*
20-
2119
/**
2220
* Logger implementation, that never print
2321
*/
24-
@RSocketLoggingApi
22+
@ExperimentalLoggingApi
2523
public object NoopLogger : Logger, LoggerFactory {
2624
override val tag: String get() = "noop"
2725
override fun isLoggable(level: LoggingLevel): Boolean = false

rsocket-core/src/commonMain/kotlin/io/rsocket/kotlin/logging/PrintLogger.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616

1717
package io.rsocket.kotlin.logging
1818

19-
import io.rsocket.kotlin.*
20-
21-
@RSocketLoggingApi
19+
@ExperimentalLoggingApi
2220
public class PrintLogger(
2321
override val tag: String,
2422
private val minLevel: LoggingLevel = LoggingLevel.INFO,

0 commit comments

Comments
 (0)