Skip to content

Commit 01f4fbf

Browse files
author
gabi
committed
removed redundant context managers from websocket transport listeners
1 parent 70516dd commit 01f4fbf

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

rsocket/transports/aiohttp_websocket.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,10 @@ async def connect(self):
5252
self._message_handler = asyncio.create_task(self.handle_incoming_ws_messages())
5353

5454
async def handle_incoming_ws_messages(self):
55-
with wrap_transport_exception():
56-
async for msg in self._ws:
57-
if msg.type == aiohttp.WSMsgType.BINARY:
58-
async for frame in self._frame_parser.receive_data(msg.data, 0):
59-
self._incoming_frame_queue.put_nowait(frame)
55+
async for msg in self._ws:
56+
if msg.type == aiohttp.WSMsgType.BINARY:
57+
async for frame in self._frame_parser.receive_data(msg.data, 0):
58+
self._incoming_frame_queue.put_nowait(frame)
6059

6160
async def send_frame(self, frame: Frame):
6261
with wrap_transport_exception():

rsocket/transports/aioquic_transport.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,14 @@ async def send_frame(self, frame: Frame):
8383
await self._quic_protocol.query(frame)
8484

8585
async def incoming_data_listener(self):
86-
with wrap_transport_exception():
87-
try:
88-
while True:
89-
data = await self._incoming_bytes_queue.get()
90-
91-
async for frame in self._frame_parser.receive_data(data, 0):
92-
self._incoming_frame_queue.put_nowait(frame)
93-
except asyncio.CancelledError:
94-
logger().debug('Asyncio task canceled: incoming_data_listener')
86+
try:
87+
while True:
88+
data = await self._incoming_bytes_queue.get()
89+
90+
async for frame in self._frame_parser.receive_data(data, 0):
91+
self._incoming_frame_queue.put_nowait(frame)
92+
except asyncio.CancelledError:
93+
logger().debug('Asyncio task canceled: incoming_data_listener')
9594

9695
async def close(self):
9796
self._listener.cancel()

rsocket/transports/quart_websocket.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from quart import websocket
44

55
from rsocket.frame import Frame
6+
from rsocket.helpers import wrap_transport_exception
67
from rsocket.logger import logger
78
from rsocket.rsocket_server import RSocketServer
89
from rsocket.transports.abstract_messaging import AbstractMessagingTransport
@@ -31,7 +32,8 @@ async def handle_incoming_ws_messages(self):
3132
logger().debug('Asyncio task canceled: quart_handle_incoming_ws_messages')
3233

3334
async def send_frame(self, frame: Frame):
34-
await websocket.send(frame.serialize())
35+
with wrap_transport_exception():
36+
await websocket.send(frame.serialize())
3537

3638
async def close(self):
3739
pass

0 commit comments

Comments
 (0)