fix: glob patterns in tsconfig.json exclude option does not work (#22)

Author: chenjiahan

package.json

@@ -36,6 +36,7 @@
     "@babel/code-frame": "^7.16.7",
     "@rspack/lite-tapable": "^1.0.0",
     "chokidar": "^3.5.3",
+    "is-glob": "^4.0.3",
     "memfs": "^4.14.0",
     "minimatch": "^9.0.5",
     "picocolors": "^1.1.1"
@@ -53,6 +54,7 @@
     "@jest/console": "^27.0.0",
     "@rspack/core": "^1.1.3",
     "@types/babel__code-frame": "^7.0.3",
+    "@types/is-glob": "^4.0.4",
     "@types/jest": "^27.4.0",
     "@types/mock-fs": "^4.13.1",
     "@types/node": "^16.4.13",

pnpm-lock.yaml

@@ -3,6 +3,7 @@ import { extname } from 'path';
 import type { FSWatcher } from 'chokidar';
 import chokidar from 'chokidar';
 import { minimatch } from 'minimatch';
+import isGlob from 'is-glob';
 import type { Compiler } from '@rspack/core';
 
 import { clearFilesChange, updateFilesChange } from '../files-change';
@@ -19,6 +20,16 @@ export function createIsIgnored(
   excluded: string[]
 ): (path: string) => boolean {
   const ignoredPatterns = ignored ? (Array.isArray(ignored) ? ignored : [ignored]) : [];
+
+  const filteredExcluded = excluded.filter((path) => {
+    // Use `minimatch` to check if the path is a glob pattern.
+    if (isGlob(path)) {
+      ignoredPatterns.push(path);
+      return false;
+    }
+    return true;
+  });
+
   const ignoredFunctions = ignoredPatterns.map((pattern) => {
     // ensure patterns are valid - see https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/594
     if (typeof pattern === 'string') {
@@ -30,9 +41,11 @@ export function createIsIgnored(
       return () => false;
     }
   });
+
   ignoredFunctions.push((path: string) =>
-    excluded.some((excludedPath) => isInsideAnotherPath(excludedPath, path))
+    filteredExcluded.some((excludedPath) => isInsideAnotherPath(excludedPath, path))
   );
+
   ignoredFunctions.push((path: string) =>
     BUILTIN_IGNORED_DIRS.some(
       (ignoredDir) => path.includes(`/${ignoredDir}/`) || path.includes(`\\${ignoredDir}\\`)

src/watch/inclusive-node-watch-file-system.ts

@@ -23,10 +23,34 @@ describe('createIsIgnored', () => {
   });
 
   it('should allow to passing string path to the second argument', () => {
+    // exclude: ["dist"] in tsconfig.json
     const isIgnored = createIsIgnored([], ['/path/to/dist']);
     expect(isIgnored(gitPath)).toBe(true);
     expect(isIgnored(nodeModulesPath)).toBe(false);
     expect(isIgnored(distModulePath)).toBe(true);
     expect(isIgnored(srcModulePath)).toBe(false);
   });
+
+  it('should allow to passing glob path to the second argument', () => {
+    // exclude: ["dist/**"] in tsconfig.json
+    const isIgnored1 = createIsIgnored([], ['/path/to/dist/**']);
+    expect(isIgnored1(gitPath)).toBe(true);
+    expect(isIgnored1(nodeModulesPath)).toBe(false);
+    expect(isIgnored1(distModulePath)).toBe(true);
+    expect(isIgnored1(srcModulePath)).toBe(false);
+
+    // exclude: ["**/dist/**"] in tsconfig.json
+    const isIgnored2 = createIsIgnored([], ['/path/to/**/dist/**']);
+    expect(isIgnored2(gitPath)).toBe(true);
+    expect(isIgnored2(nodeModulesPath)).toBe(true);
+    expect(isIgnored2(distModulePath)).toBe(true);
+    expect(isIgnored2(srcModulePath)).toBe(false);
+
+    // exclude: ["**/dist/*"] in tsconfig.json
+    const isIgnored3 = createIsIgnored([], ['/path/to/**/dist/*']);
+    expect(isIgnored3(gitPath)).toBe(true);
+    expect(isIgnored3(nodeModulesPath)).toBe(true);
+    expect(isIgnored3(distModulePath)).toBe(true);
+    expect(isIgnored3(srcModulePath)).toBe(false);
+  });
 });