Skip to content

Commit 92c4b4f

Browse files
authored
Merge pull request #56 from rspec/rails-7-builds
Add Rails 7 support
2 parents 19d09b8 + a86264f commit 92c4b4f

File tree

5 files changed

+42
-3
lines changed

5 files changed

+42
-3
lines changed

.github/workflows/ci.yml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,34 @@ jobs:
2323
fail-fast: false
2424
matrix:
2525
include:
26+
# Rails 7.1 builds >= 2.7
27+
- ruby: 3.2
28+
env:
29+
RAILS_VERSION: '~> 7.1.0'
30+
- ruby: 3.1
31+
env:
32+
RAILS_VERSION: '~> 7.1.0'
33+
- ruby: '3.0'
34+
env:
35+
RAILS_VERSION: '~> 7.1.0'
36+
- ruby: 2.7
37+
env:
38+
RAILS_VERSION: '~> 7.1.0'
39+
40+
# Rails 7.0 builds >= 2.7
41+
- ruby: 3.2
42+
env:
43+
RAILS_VERSION: '~> 7.0.0'
44+
- ruby: 3.1
45+
env:
46+
RAILS_VERSION: '~> 7.0.0'
47+
- ruby: '3.0'
48+
env:
49+
RAILS_VERSION: '~> 7.0.0'
50+
- ruby: 2.7
51+
env:
52+
RAILS_VERSION: '~> 7.0.0'
53+
2654
# Rails 6.1 builds >= 2.5
2755
- ruby: 3.1
2856
env:

Gemfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,3 +64,7 @@ else
6464
end
6565

6666
gem "i18n", '< 0.7.0' if RUBY_VERSION < '1.9.3'
67+
68+
if RUBY_VERSION < '2.0.0'
69+
gem 'cucumber', "< 3"
70+
end

cucumber.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
default: --require features --format progress --tags ~@wip
2-
pretty: --require features --format pretty --tags ~@wip
1+
default: --require features --format progress --tags not(@wip)
2+
pretty: --require features --format pretty --tags not(@wip)
33
wip: --require features --tags @wip

lib/rspec/active_model/mocks/mocks.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,13 @@ def mock_model(string_or_model_class, stubs = {})
9999
model_class = Object.const_set(string_or_model_class, Class.new do
100100
extend ::ActiveModel::Naming
101101
def self.primary_key; :id; end
102+
103+
# For detection of being a valid association in 7+
104+
def self.<(other); other == ActiveRecord::Base; end
105+
def self._reflect_on_association(_other); nil; end
106+
def self.composite_primary_key?; false; end
107+
def self.has_query_constraints?; false; end
108+
def self.param_delimiter; "-"; end
102109
end)
103110
end
104111
else

rspec-activemodel-mocks.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Gem::Specification.new do |s|
4646
s.add_development_dependency "rake", "~> 13.0.0"
4747
end
4848

49-
s.add_development_dependency 'cucumber', '~> 1.3'
49+
s.add_development_dependency 'cucumber', '>= 1.3'
5050
s.add_development_dependency 'aruba', '~> 0.4.11'
5151
s.add_development_dependency 'ZenTest', '~> 4.11.2'
5252
s.add_development_dependency(%q<activerecord>, [">= 3.0"])

0 commit comments

Comments
 (0)