Switch from hash rocket style to 1.9 style hash keys (#2224)

Author: hmtanbir

.rubocop_todo.yml

@@ -18,10 +18,6 @@ Metrics/MethodLength:
 Style/EachWithObject:
   Enabled: false
 
-# ruby 1.8.7 only had support for hash rockets
-Style/HashSyntax:
-  EnforcedStyle: hash_rockets # default: ruby19
-
 # the new lambda syntax was not supported in ruby 1.8.7
 Style/Lambda:
   Enabled: false

Capybara.md

@@ -73,5 +73,5 @@ behavior and accepting the risks associated with doing so:
 
     # not recommended!
     RSpec.configure do |c|
-      c.include Capybara::DSL, :file_path => "spec/requests"
+      c.include Capybara::DSL, file_path: "spec/requests"
     end

Changelog.md

@@ -344,10 +344,10 @@ Enhancements:
 * Improve controller and routing spec calls to `routes` by using `yield`
   instead of `call`. (Anton Davydov, #1308)
 * Add support for `ActiveJob` specs as standard `RSpec::Rails::RailsExampleGoup`s
-  via both `:type => :job` and inferring type from spec directory `spec/jobs`.
+  via both `type: :job` and inferring type from spec directory `spec/jobs`.
   (Gabe Martin-Dempesy, #1361)
 * Include `RSpec::Rails::FixtureSupport` into example groups using metadata
-  `:use_fixtures => true`. (Aaron Kromer, #1372)
+  `use_fixtures: true`. (Aaron Kromer, #1372)
 * Include `rspec:request` generator for generating request specs; this is an
   alias of `rspec:integration` (Aaron Kromer, #1378)
 * Update `rails_helper` generator with a default check to abort the spec run
@@ -488,7 +488,7 @@ Enhancements:
 Bug Fixes:
 
 * Fix an inconsistency in the generated scaffold specs for a controller. (Andy Waite)
-* Ensure `config.before(:all, :type => <type>)` hooks run before groups
+* Ensure `config.before(:all, type: <type>)` hooks run before groups
   of the given type, even when the type is inferred by the file
   location. (Jon Rowe, Myron Marston)
 * Switch to parsing params with `Rack::Utils::parse_nested_query` to match Rails.
@@ -938,7 +938,7 @@ This release is compatible with rails-3.1.0.rc1, but not rails-3.1.0.beta1
 * Enhancements
   * include ApplicationHelper in helper object in helper specs
   * include request spec extensions in files in spec/integration
-  * include controller spec extensions in groups that use :type => :controller
+  * include controller spec extensions in groups that use type: :controller
     * same for :model, :view, :helper, :mailer, :request, :routing
 
 * Bug fixes

Gemfile

@@ -7,12 +7,12 @@ gemspec
 rspec_dependencies_gemfile = File.expand_path("../Gemfile-rspec-dependencies", __FILE__)
 eval_gemfile rspec_dependencies_gemfile
 
-gem 'yard', '~> 0.8.7', :require => false
+gem 'yard', '~> 0.8.7', require: false
 
 ### deps for rdoc.info
 group :documentation do
-  gem 'redcarpet', '~> 3.4.0', platforms: [:ruby]
   gem 'github-markup', '~> 3.0.3'
+  gem 'redcarpet', '~> 3.4.0', platforms: [:ruby]
   gem 'relish', '~> 0.7.1'
 end
 
@@ -36,8 +36,8 @@ else
 end
 
 if MAJOR >= 6
+  gem 'selenium-webdriver', '~> 3.5', require: false
   gem 'sqlite3', '~> 1.4', platforms: [:ruby]
-  gem 'selenium-webdriver', '~> 3.5', :require => false
 else
   gem 'sqlite3', '~> 1.3.6', platforms: [:ruby]
 end
@@ -57,7 +57,7 @@ if RUBY_VERSION < '2.4.0'
   gem 'minitest', '< 5.12.0'
 end
 
-gem 'capybara', '~> 2.13', :require => false
+gem 'capybara', '~> 2.13', require: false
 
 if MAJOR < 6
   gem 'nokogiri', '1.8.5'

README.md

@@ -35,7 +35,7 @@ Use **[`rspec-rails` 1.x][]** for Rails 2.x.
    # (requires master-branch versions of all related RSpec libraries)
    group :development, :test do
      %w[rspec-core rspec-expectations rspec-mocks rspec-rails rspec-support].each do |lib|
-       gem lib, :git => "https://github.com/rspec/#{lib}.git", :branch => 'master'
+       gem lib, git: "https://github.com/rspec/#{lib}.git", branch: 'master'
      end
    end
    ```

features/matchers/have_broadcasted_matcher.feature

@@ -104,7 +104,7 @@ Feature: have_broadcasted matcher
       """ruby
       require "rails_helper"
 
-      RSpec.describe ChatChannel, :type => :channel do
+      RSpec.describe ChatChannel, type: :channel do
         it "successfully subscribes" do
           user = User.new(42)
 

features/matchers/have_enqueued_mail_matcher.feature

@@ -33,7 +33,7 @@ Feature: have_enqueued_mail matcher
         it "matches with enqueued mailer" do
           ActiveJob::Base.queue_adapter = :test
           expect {
-            NotificationsMailer.signup.deliver_later(:wait_until => Date.tomorrow.noon)
+            NotificationsMailer.signup.deliver_later(wait_until: Date.tomorrow.noon)
           }.to have_enqueued_mail.at(Date.tomorrow.noon)
         end
       end

features/step_definitions/additional_cli_steps.rb

@@ -1,10 +1,10 @@
 begin
   require "active_job"
-rescue LoadError # rubocop:disable Lint/HandleExceptions
+rescue LoadError # rubocop:disable Lint/SuppressedException
 end
 begin
   require "action_cable"
-rescue LoadError # rubocop:disable Lint/HandleExceptions
+rescue LoadError # rubocop:disable Lint/SuppressedException
 end
 
 require "rails/version"

lib/generators/rspec/controller/controller_generator.rb

@@ -4,12 +4,12 @@ module Rspec
   module Generators
     # @private
     class ControllerGenerator < Base
-      argument :actions, :type => :array, :default => [], :banner => "action action"
+      argument :actions, type: :array, default: [], banner: "action action"
 
-      class_option :template_engine, :desc => "Template engine to generate view files"
-      class_option :controller_specs, :type => :boolean, :default => true, :desc => "Generate controller specs"
-      class_option :view_specs,       :type => :boolean, :default => true, :desc => "Generate view specs"
-      class_option :routing_specs,    :type => :boolean, :default => false, :desc => "Generate routing specs"
+      class_option :template_engine,  desc: "Template engine to generate view files"
+      class_option :controller_specs, type: :boolean, default: true, desc: "Generate controller specs"
+      class_option :view_specs,       type: :boolean, default: true, desc: "Generate view specs"
+      class_option :routing_specs,    type: :boolean, default: false, desc: "Generate routing specs"
 
       def generate_controller_spec
         return unless options[:controller_specs]

lib/generators/rspec/controller/templates/routing_spec.rb

@@ -5,7 +5,7 @@
   describe 'routing' do
 <% for action in actions -%>
     it 'routes to #<%= action %>' do
-      expect(:get => "/<%= class_name.underscore %>/<%= action %>").to route_to("<%= class_name.underscore %>#<%= action  %>")
+      expect(get: "/<%= class_name.underscore %>/<%= action %>").to route_to("<%= class_name.underscore %>#<%= action  %>")
     end
 <% end -%>
   end