Skip to content

Commit 7b9ba28

Browse files
authored
Correct route_to documentation in README
The `route_to` matcher [delegates to assert_recognizes](https://github.com/rspec/rspec-rails/blob/main/lib/rspec/rails/matchers/routing_matchers.rb#L27). This assertion only tests path=>params, not that the provided params also generate the expected path [as `assert_routing` does](https://api.rubyonrails.org/v6.1.0/classes/ActionDispatch/Assertions/RoutingAssertions.html). It would be great to have an rspec matcher for the inverse (`generate_route` perhaps?) but at the very least I figured the readme should be corrected. The full docs on relishapp.com seem to be correct already.
1 parent 18f3e30 commit 7b9ba28

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

README.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -187,17 +187,17 @@ In addition to [the matchers that come standard in RSpec][],
187187
here are some extras that make it easier
188188
to test the various parts of a Rails system:
189189

190-
| RSpec matcher | Delegates to | Available in | Notes |
191-
| ------------------------ | ----------------- | ------------------------------- | -------------------------------------------------------- |
192-
| [`be_a_new`][] | | all | primarily intended for controller specs |
193-
| [`render_template`][] | `assert_template` | request / controller / view | use with `expect(response).to` |
194-
| [`redirect_to`][] | `assert_redirect` | request / controller | use with `expect(response).to` |
195-
| [`route_to`] | `assert_routing` | routing / controller | use with `expect(...).to route_to` |
196-
| [`be_routable`] | | routing / controller | use with `expect(...).not_to be_routable` |
197-
| [`have_http_status`][] | | request / controller / feature | |
198-
| [`match_array`][] | | all | for comparing arrays of ActiveRecord objects |
199-
| [`have_been_enqueued`][] | | all | requires config: `ActiveJob::Base.queue_adapter = :test` |
200-
| [`have_enqueued_job`][] | | all | requires config: `ActiveJob::Base.queue_adapter = :test` |
190+
| RSpec matcher | Delegates to | Available in | Notes |
191+
| ------------------------ | ------------------- | ------------------------------- | -------------------------------------------------------- |
192+
| [`be_a_new`][] | | all | primarily intended for controller specs |
193+
| [`render_template`][] | `assert_template` | request / controller / view | use with `expect(response).to` |
194+
| [`redirect_to`][] | `assert_redirect` | request / controller | use with `expect(response).to` |
195+
| [`route_to`] | `assert_recognizes` | routing / controller | use with `expect(...).to route_to` |
196+
| [`be_routable`] | | routing / controller | use with `expect(...).not_to be_routable` |
197+
| [`have_http_status`][] | | request / controller / feature | |
198+
| [`match_array`][] | | all | for comparing arrays of ActiveRecord objects |
199+
| [`have_been_enqueued`][] | | all | requires config: `ActiveJob::Base.queue_adapter = :test` |
200+
| [`have_enqueued_job`][] | | all | requires config: `ActiveJob::Base.queue_adapter = :test` |
201201

202202
Follow the links above for examples of how each matcher is used.
203203

0 commit comments

Comments
 (0)