Merge pull request #2188 from sinsoku/fix_duplicate_configuration_for_driver

Fix an issue where driven_by(:selenium) is always called

Author: JonRowe

lib/rspec/rails/example/system_example_group.rb

@@ -85,16 +85,19 @@ def app
         def initialize(*args, &blk)
           super(*args, &blk)
           @driver = nil
+
+          self.class.before do
+            # A user may have already set the driver, so only default if driver
+            # is not set
+            driven_by(:selenium) unless @driver
+          end
         end
 
         def driven_by(*args, &blk)
           @driver = ::ActionDispatch::SystemTestCase.driven_by(*args, &blk).tap(&:use)
         end
 
         before do
-          # A user may have already set the driver, so only default if driver
-          # is not set
-          driven_by(:selenium) unless @driver
           @routes = ::Rails.application.routes
         end
 

spec/rspec/rails/example/system_example_group_spec.rb

@@ -18,6 +18,47 @@ module RSpec::Rails
           end
         end
       end
+
+      describe '#driver' do
+        it 'uses :selenium driver by default' do
+          group = RSpec::Core::ExampleGroup.describe do
+            include SystemExampleGroup
+          end
+          example = group.new
+          group.hooks.run(:before, :example, example)
+
+          expect(Capybara.current_driver).to eq :selenium
+        end
+
+        it 'sets :rack_test driver using by before_action' do
+          group = RSpec::Core::ExampleGroup.describe do
+            include SystemExampleGroup
+
+            before do
+              driven_by(:rack_test)
+            end
+          end
+          example = group.new
+          group.hooks.run(:before, :example, example)
+
+          expect(Capybara.current_driver).to eq :rack_test
+        end
+
+        it 'calls :driven_by method only once' do
+          group = RSpec::Core::ExampleGroup.describe do
+            include SystemExampleGroup
+
+            before do
+              driven_by(:rack_test)
+            end
+          end
+          example = group.new
+          allow(example).to receive(:driven_by).and_call_original
+          group.hooks.run(:before, :example, example)
+
+          expect(example).to have_received(:driven_by).once
+        end
+      end
     end
   end
 end