Cleaning up from linting

Author: andrewshell

.eslintrc.json

@@ -8,6 +8,7 @@
     	"es6": true
     },
     "rules": {
-        "no-underscore-dangle": "off"
+        "no-underscore-dangle": "off",
+        "no-continue": "off"
     }
 }

controllers/ping.js

@@ -36,10 +36,10 @@
     }
 
     router.post('/', urlencodedParser, function (req, res) {
-        const params = parsePingParams(req);
-        const result = ping(params.url)
-            .then(result => processResponse(req, res, result))
-            .catch(err => handleError(req, res, err));
+        const params = parsePingParams(req),
+            result = ping(params.url)
+                .then(result => processResponse(req, res, result))
+                .catch(err => handleError(req, res, err));
     });
 
     module.exports = router;

controllers/please-notify.js

@@ -1,7 +1,7 @@
 (function () {
     "use strict";
 
-    var bodyParser = require('body-parser'),
+    const bodyParser = require('body-parser'),
         errorResult = require('../services/error-result'),
         express = require('express'),
         parseNotifyParams = require('../services/parse-notify-params'),
@@ -34,14 +34,14 @@
     }
 
     router.post('/', urlencodedParser, function (req, res) {
-        const params = parseNotifyParams(req);
-        const result = pleaseNotify(
-            params.apiurl,
-            params.urlList,
-            params.diffDomain
-        )
-            .then(result => processResponse(req, res, result))
-            .catch(err => handleError(req, res, err));
+        const params = parseNotifyParams(req),
+            result = pleaseNotify(
+                params.apiurl,
+                params.urlList,
+                params.diffDomain
+            )
+                .then(result => processResponse(req, res, result))
+                .catch(err => handleError(req, res, err));
     });
 
     module.exports = router;

migrations/20170530180056-add-log-events.js

@@ -6,21 +6,20 @@
 
     async function initResource(resourceUrl) {
         const resource = await mongodb.get()
-            .collection('resources')
-            .findOne({
-                _id: resourceUrl
-            });
-
-        const defaultResource = {
-            _id: resourceUrl,
-            flDirty: true,
-            lastSize: 0,
-            lastHash: '',
-            ctChecks: 0,
-            whenLastCheck: moment.utc('0', 'x').format(),
-            ctUpdates: 0,
-            whenLastUpdate: moment.utc('0', 'x').format()
-        };
+                .collection('resources')
+                .findOne({
+                    _id: resourceUrl
+                }),
+            defaultResource = {
+                _id: resourceUrl,
+                flDirty: true,
+                lastSize: 0,
+                lastHash: '',
+                ctChecks: 0,
+                whenLastCheck: moment.utc('0', 'x').format(),
+                ctUpdates: 0,
+                whenLastUpdate: moment.utc('0', 'x').format()
+            };
 
         return Object.assign({}, defaultResource, resourceUrl || {});
     }

services/init-resource.js

@@ -8,7 +8,7 @@
         };
 
     module.exports = {
-        connect: async function(uri) {
+        connect: async function (uri) {
             if (state.db) {
                 return;
             }
@@ -53,10 +53,10 @@
                     return client.db();
                 });
         },
-        get: function() {
+        get: function () {
             return state.db;
         },
-        close: async function() {
+        close: async function () {
             if (state.db) {
                 return state.db.close()
                     .then(() => {
@@ -65,4 +65,4 @@
             }
         }
     };
-}());
+}());

services/mongodb.js

@@ -10,13 +10,12 @@
             testUrl = apiurl + '?' + querystring.stringify({
                 'url': resourceUrl,
                 'challenge': challenge
+            }),
+            res = await request({
+                uri: testUrl,
+                resolveWithFullResponse: true
             });
 
-        const res = await request({
-            uri: testUrl,
-            resolveWithFullResponse: true
-        });
-
         if (res.statusCode < 200 || res.statusCode > 299 || res.body !== challenge) {
             throw new Error('Notification Failed');
         }

services/notify-one-challenge.js

@@ -5,13 +5,13 @@
 
     async function notifyOne(resourceUrl, apiurl) {
         const res = await request({
-                method: 'POST',
-                uri: apiurl,
-                data: {
-                    'url': resourceUrl
-                },
-                resolveWithFullResponse: true
-            });
+            method: 'POST',
+            uri: apiurl,
+            data: {
+                'url': resourceUrl
+            },
+            resolveWithFullResponse: true
+        });
 
         if (res.statusCode < 200 || res.statusCode > 299) {
             throw new Error('Notification Failed');