Adding test for multiple subscribers on same domain and better error handling

Author: andrewshell

.node-version

@@ -1 +1 @@
-14
+16

controllers/ping.js

@@ -2,6 +2,7 @@
     "use strict";
 
     const bodyParser = require('body-parser'),
+        ErrorResponse = require('../services/error-response'),
         errorResult = require('../services/error-result'),
         express = require('express'),
         parsePingParams = require('../services/parse-ping-params'),
@@ -30,7 +31,9 @@
     }
 
     function handleError(req, res, err) {
-        console.error(err);
+        if (!(err instanceof ErrorResponse)) {
+            console.error(err);
+        }
         processResponse(req, res, errorResult(err.message));
     }
 

controllers/please-notify.js

@@ -2,6 +2,7 @@
     "use strict";
 
     const bodyParser = require('body-parser'),
+        ErrorResponse = require('../services/error-response'),
         errorResult = require('../services/error-result'),
         express = require('express'),
         parseNotifyParams = require('../services/parse-notify-params'),
@@ -30,7 +31,9 @@
     }
 
     function handleError(req, res, err) {
-        console.error(err);
+        if (!(err instanceof ErrorResponse)) {
+            console.error(err);
+        }
         processResponse(req, res, errorResult(err.message));
     }
 

controllers/rpc2.js

@@ -2,6 +2,7 @@
     "use strict";
 
     const bodyParser = require('body-parser'),
+        ErrorResponse = require('../services/error-response'),
         express = require('express'),
         parseRpcRequest = require('../services/parse-rpc-request'),
         parseNotifyParams = require('../services/parse-notify-params'),
@@ -26,7 +27,9 @@
     }
 
     function handleError(req, res, err) {
-        console.error(err);
+        if (!(err instanceof ErrorResponse)) {
+            console.error(err);
+        }
         processResponse(req, res, rpcReturnFault(4, err.message));
     }
 

controllers/view-log.js

@@ -1,7 +1,8 @@
 (function () {
     "use strict";
 
-    const errorResult = require('../services/error-result'),
+    const ErrorResponse = require('../services/error-response'),
+        errorResult = require('../services/error-result'),
         express = require('express'),
         logEmitter = require('../services/log-emitter'),
         mongodb = require('../services/mongodb'),
@@ -47,7 +48,9 @@
     }
 
     function handleError(req, res, err) {
-        console.error(err);
+        if (!(err instanceof ErrorResponse)) {
+            console.error(err);
+        }
         processResponse(req, res, errorResult(err.message));
     }