Skip to content

Commit 1245527

Browse files
authored
test: run type tests on CI (#49)
1 parent f06d54f commit 1245527

File tree

6 files changed

+29
-65
lines changed

6 files changed

+29
-65
lines changed

.github/workflows/ci.yml

Lines changed: 22 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,66 +1,46 @@
1-
name: 'ci'
1+
name: 'CI'
22
on: [push, pull_request]
33

4-
jobs:
5-
# lint:
6-
# runs-on: ubuntu-latest
7-
# steps:
8-
# - uses: actions/checkout@v2
9-
10-
# - name: Install Pnpm
11-
# run: corepack enable
12-
13-
# - name: Setup Node.js 18.x
14-
# uses: actions/setup-node@v4
15-
# with:
16-
# node-version: 18.x
17-
# cache: 'pnpm'
18-
19-
# - name: Install Dependencies
20-
# run: pnpm i
21-
22-
# - name: Run lint
23-
# run: pnpm run lint
4+
permissions:
5+
contents: read
246

7+
jobs:
258
test:
269
runs-on: ubuntu-latest
27-
strategy:
28-
matrix:
29-
node: ['18']
3010
steps:
3111
- uses: actions/checkout@v4
3212
- uses: actions/setup-node@v4
3313
with:
34-
node-version: ${{ matrix.node }}
14+
node-version: 22
3515
- name: Install Pnpm
3616
run: corepack enable
3717

38-
- name: Setup Node.js 18.x
18+
- name: Setup Node.js
3919
uses: actions/setup-node@v4
4020
with:
41-
node-version: 18.x
21+
node-version: 22
4222
cache: 'pnpm'
4323

4424
- name: Install Dependencies
4525
run: pnpm i
4626
- name: Run unit tests
4727
run: pnpm run test
4828

49-
# test-types:
50-
# runs-on: ubuntu-latest
51-
# steps:
52-
# - uses: actions/checkout@v2
53-
# - name: Install Pnpm
54-
# run: corepack enable
29+
test-types:
30+
runs-on: ubuntu-latest
31+
steps:
32+
- uses: actions/checkout@v2
33+
- name: Install Pnpm
34+
run: corepack enable
5535

56-
# - name: Setup Node.js 18.x
57-
# uses: actions/setup-node@v4
58-
# with:
59-
# node-version: 18.x
60-
# cache: 'pnpm'
36+
- name: Setup Node.js
37+
uses: actions/setup-node@v4
38+
with:
39+
node-version: 22
40+
cache: 'pnpm'
6141

62-
# - name: Install Dependencies
63-
# run: pnpm i
42+
- name: Install Dependencies
43+
run: pnpm i
6444

65-
# - name: Run type declaration tests
66-
# run: pnpm run test:types
45+
- name: Run type declaration tests
46+
run: pnpm run test:types

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
"packageManager": "pnpm@10.5.1",
2020
"scripts": {
2121
"fix": "yarn lint:fix && yarn style:fix",
22-
"lint": "echo 'pass'",
23-
"lint:fix": "echo 'pass'",
2422
"style": "prettier --check .",
2523
"style:fix": "prettier --write .",
2624
"test": "rstest run",

renovate.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

types/test/rspack-chain-tests.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ config
182182
.modules.add('index.js')
183183
.end()
184184
.aliasFields.add('foo')
185-
.add(['foo'])
185+
// Rspack does not support this
186+
// .add(['foo'])
186187
.end()
187188
.conditionNames.add('foo')
188189
.end()
@@ -207,7 +208,8 @@ config
207208
mainFields: ['browser', 'module'],
208209
})
209210
.end()
210-
.cachePredicate(({ path, request }) => true)
211+
// Rspack does not support this
212+
// .cachePredicate(({ path, request }) => true)
211213
.cacheWithContext(true)
212214
.enforceExtension(true)
213215
.symlinks(true)

types/test/tsconfig.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
{
22
"compilerOptions": {
33
"module": "commonjs",
4-
"lib": ["es6"],
4+
"lib": ["es2022"],
55
"noImplicitAny": true,
66
"noImplicitThis": true,
7+
"skipLibCheck": true,
78
"strictNullChecks": true,
89
"strictFunctionTypes": true,
910
"noEmit": true,
10-
"baseUrl": ".",
1111
"paths": {
1212
"rspack-chain": ["../index.d.ts"]
1313
}
1414
},
15-
"files": ["../index.d.ts", "rspack-chain-tests.ts"],
16-
"compileOnSave": false
15+
"files": ["../index.d.ts", "rspack-chain-tests.ts"]
1716
}

types/typings.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)