Skip to content

Commit f83d8cd

Browse files
committed
chore: fix Rsbuild again
1 parent 9b3f3f7 commit f83d8cd

File tree

8 files changed

+191
-150
lines changed

8 files changed

+191
-150
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@ workspace
66
.pnpm-debug.log
77
.idea
88
website/src/data/remote/*.json
9+
website/dist

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
v22

AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
The CLI entry point lives in `ecosystem-ci.ts`, handling argument parsing, stack selection, and GitHub Actions plumbing. Shared helpers (`runInRepo`, git utilities, bootstrap logic) reside in `utils.ts`, while DTOs are defined in `types.d.ts`. Integration suites are colocated under `tests/<stack>/` (for example `tests/rspack/nuxt.ts` or `tests/rsbuild/plugins.ts`) and export an async `test(options: RunOptions)` function. Runtime clones are created under `workspace/`; treat this directory as disposable and keep it untracked. The `website/` directory hosts the deployed page, which pulls fresh data from the `data` branch via ecosystem CI rendering before the scheduled deployment jobs run.
55

66
## Build, Test, and Development Commands
7-
Use `pnpm install` to bootstrap dependencies (Node ≥18). Run targeted suites with `pnpm test -- --stack <stack> [suite]`, e.g. `pnpm test -- --stack rsbuild plugins`. Bisect regressions via `pnpm bisect -- --stack <stack>`. Execute `pnpm lint` to run `biome check .`. After cloning, `pnpm prepare` installs `simple-git-hooks` so the Biome pre-commit hook fires locally.
7+
Use `pnpm install` to bootstrap dependencies (Node ≥18). Run targeted suites with `pnpm test --stack <stack> [suite]`, e.g. `pnpm test --stack rsbuild plugins`. Bisect regressions via `pnpm bisect --stack <stack>`. Execute `pnpm lint` to run `biome check .`. After cloning, `pnpm prepare` installs `simple-git-hooks` so the Biome pre-commit hook fires locally.
88

99
## Coding Style & Naming Conventions
1010
Biome enforces space indentation, single quotes, normalized imports, and the shared lint rules. Follow the strict TypeScript settings in `tsconfig.json` (ESNext target, NodeNext resolution, `noImplicitOverride`). Name suite files in lowercase or kebab-case (`tests/rspack/lynx-stack.ts`), keep helpers camelCase, and reserve `test` exports for suite entry points.
@@ -13,7 +13,7 @@ Biome enforces space indentation, single quotes, normalized imports, and the sha
1313
Suites boot via `setupEnvironment` and must remain idempotent so reruns start clean. Prefer `runInRepo` with explicit `repo`, `branch`, `test`, and overrides so reviewers can audit each step. When adding scenarios, mirror the minimal patterns (for example `tests/rsbuild/examples.ts` with `test: ['build:rsbuild']`) and document any required environment tweaks.
1414

1515
## Commit & Pull Request Guidelines
16-
Commits follow short, imperative subjects (≤72 chars), elaborating in the body only when behavior changes. PRs should justify the change, list affected stacks or utilities, and include the exact validation command, e.g. `pnpm test -- --stack rspack modernjs`. Attach logs or screenshots for CI changes and highlight any new secrets or webhooks reviewers must configure.
16+
Commits follow short, imperative subjects (≤72 chars), elaborating in the body only when behavior changes. PRs should justify the change, list affected stacks or utilities, and include the exact validation command, e.g. `pnpm test --stack rspack modernjs`. Attach logs or screenshots for CI changes and highlight any new secrets or webhooks reviewers must configure.
1717

1818
## Environment & Tooling Notes
1919
The runner exports `ECOSYSTEM_CI`, `TURBO_FORCE`, and memory-safe `NODE_OPTIONS`; avoid overriding them unless a suite explicitly requires it. Keep `workspace/` untracked, and never commit runtime artifacts. Remember that network-dependent steps may need explicit approval in restricted environments.

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,10 @@ Workflows are scheduled to run automatically every day
1919

2020
- clone this repo
2121
- run `pnpm i`
22-
- run `pnpm test -- --stack <stack>` to run every suite under the selected stack (`rsbuild`, `rspack`, `rstest`, `rslib`, `rsdoctor`, or `rslint`)
23-
- run `pnpm test -- --stack rspack` to execute all Rspack suites (available stacks: `rsbuild`, `rspack`, `rstest`, `rslib`, `rsdoctor`, `rslint`)
24-
- run `pnpm test -- --stack rslib` to execute all Rslib suites
25-
- run `pnpm test -- --stack rsbuild plugins` to target a specific suite
22+
- run `pnpm test --stack <stack>` to run every suite under the selected stack (`rsbuild`, `rspack`, `rstest`, `rslib`, `rsdoctor`, or `rslint`)
23+
- run `pnpm test --stack rspack` to execute all Rspack suites (available stacks: `rsbuild`, `rspack`, `rstest`, `rslib`, `rsdoctor`, `rslint`)
24+
- run `pnpm test --stack rslib` to execute all Rslib suites
25+
- run `pnpm test --stack rsbuild plugins` to target a specific suite
2626
- or invoke `tsx ecosystem-ci.ts` directly for advanced commands such as `build`, `run-suites`, or `bisect`
2727

2828
The version selection flags apply to the chosen stack:
@@ -34,8 +34,8 @@ The repositories are checked out into `workspace` subdirectory as shallow clones
3434

3535
### Cheat sheet
3636

37-
- `pnpm test -- --stack rspack --release nightly <suite>`: run a nightly release of the selected stack
38-
- `pnpm test -- --stack rsbuild --branch main --suite-branch update-rsbuild <suite>`: use `update-rsbuild` branch for the suite to test `main`
37+
- `pnpm test --stack rspack --release nightly <suite>`: run a nightly release of the selected stack
38+
- `pnpm test --stack rsbuild --branch main --suite-branch update-rsbuild <suite>`: use `update-rsbuild` branch for the suite to test `main`
3939

4040
# How to add a new integration test
4141

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
},
4747
"packageManager": "pnpm@10.19.0",
4848
"engines": {
49-
"node": ">=18",
50-
"pnpm": "10.19.0"
49+
"node": ">=22"
5150
}
5251
}

tests/rsbuild/plugins.ts

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -10,32 +10,32 @@ export async function test(options: RunOptions) {
1010
}> = [];
1111

1212
const plugins = [
13-
'rspack-contrib/rsbuild-plugin-umd',
13+
// 'rspack-contrib/rsbuild-plugin-umd',
1414
'rspack-contrib/rsbuild-plugin-eslint',
15-
'rspack-contrib/rsbuild-plugin-mdx',
16-
'rspack-contrib/rsbuild-plugin-google-analytics',
17-
'rspack-contrib/rsbuild-plugin-html-minifier-terser',
18-
'rspack-contrib/rsbuild-plugin-open-graph',
19-
'rspack-contrib/rsbuild-plugin-image-compress',
20-
'rspack-contrib/rsbuild-plugin-css-minimizer',
21-
'rspack-contrib/rsbuild-plugin-typed-css-modules',
22-
'rspack-contrib/rsbuild-plugin-pug',
23-
'rspack-contrib/rsbuild-plugin-toml',
24-
'rspack-contrib/rsbuild-plugin-template',
25-
'rspack-contrib/rsbuild-plugin-styled-components',
26-
'rspack-contrib/rsbuild-plugin-rem',
27-
'rspack-contrib/rsbuild-plugin-vue2',
28-
'rspack-contrib/rsbuild-plugin-yaml',
29-
'rspack-contrib/rsbuild-plugin-vue2-jsx',
30-
'rspack-contrib/rsbuild-plugin-type-check',
31-
'rspack-contrib/rsbuild-plugin-source-build',
32-
'rspack-contrib/rsbuild-plugin-node-polyfill',
33-
'rspack-contrib/rsbuild-plugin-ejs',
34-
'rspack-contrib/rsbuild-plugin-check-syntax',
35-
'rspack-contrib/rsbuild-plugin-basic-ssl',
36-
'rspack-contrib/rsbuild-plugin-vue-jsx',
37-
'rspack-contrib/rsbuild-plugin-assets-retry',
38-
'rspack-contrib/rsbuild-plugin-tailwindcss',
15+
// 'rspack-contrib/rsbuild-plugin-mdx',
16+
// 'rspack-contrib/rsbuild-plugin-google-analytics',
17+
// 'rspack-contrib/rsbuild-plugin-html-minifier-terser',
18+
// 'rspack-contrib/rsbuild-plugin-open-graph',
19+
// 'rspack-contrib/rsbuild-plugin-image-compress',
20+
// 'rspack-contrib/rsbuild-plugin-css-minimizer',
21+
// 'rspack-contrib/rsbuild-plugin-typed-css-modules',
22+
// 'rspack-contrib/rsbuild-plugin-pug',
23+
// 'rspack-contrib/rsbuild-plugin-toml',
24+
// 'rspack-contrib/rsbuild-plugin-template',
25+
// 'rspack-contrib/rsbuild-plugin-styled-components',
26+
// 'rspack-contrib/rsbuild-plugin-rem',
27+
// 'rspack-contrib/rsbuild-plugin-vue2',
28+
// 'rspack-contrib/rsbuild-plugin-yaml',
29+
// 'rspack-contrib/rsbuild-plugin-vue2-jsx',
30+
// 'rspack-contrib/rsbuild-plugin-type-check',
31+
// 'rspack-contrib/rsbuild-plugin-source-build',
32+
// 'rspack-contrib/rsbuild-plugin-node-polyfill',
33+
// 'rspack-contrib/rsbuild-plugin-ejs',
34+
// 'rspack-contrib/rsbuild-plugin-check-syntax',
35+
// 'rspack-contrib/rsbuild-plugin-basic-ssl',
36+
// 'rspack-contrib/rsbuild-plugin-vue-jsx',
37+
// 'rspack-contrib/rsbuild-plugin-assets-retry',
38+
// 'rspack-contrib/rsbuild-plugin-tailwindcss',
3939
];
4040

4141
const { workspace } = options;

tests/rspress/utils/_netlify.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export async function deployPreviewToNetlify(options: DeployOptions) {
4040

4141
const cliSpecifier = process.env.RSPRESS_NETLIFY_CLI ?? DEFAULT_NETLIFY_CLI;
4242
const result =
43-
await $`pnpm --package=${cliSpecifier} dlx netlify deploy --dir=${outputDir} --alias=${alias} --message=${message} --site=${siteId} --auth=${authToken} --json`;
43+
await $`pnpm --package=${cliSpecifier} dlx netlify deploy --dir=${outputDir} --alias=${alias} --message=${message} --site=${siteId} --auth=${authToken} --json --no-build`;
4444

4545
try {
4646
const parsed = JSON.parse(result);

0 commit comments

Comments
 (0)