You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: restructure storybook-sync skill and add .agents/skills layout
Move skill from .claude/skills/storybook-sync-checker to .agents/skills/storybook-sync
with a symlink at .claude/skills, matching the rstest repo convention.
Refactor SKILL.md: move priority criteria before workflow, flesh out
direct analysis steps, parameterize example commands, add issue
creation step.
Copy file name to clipboardExpand all lines: .agents/skills/storybook-sync/SKILL.md
+58-51Lines changed: 58 additions & 51 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,5 +1,5 @@
1
1
---
2
-
name: storybook-sync-checker
2
+
name: storybook-sync
3
3
internal: true
4
4
description: Check and analyze upstream Storybook repository changes that may need to be synced to storybook-rsbuild. Use this skill whenever the user wants to check for upstream Storybook changes, review what's new in the official Storybook repo, identify changes needing sync, or compare storybook-rsbuild against the upstream. Activate for phrases like "check upstream", "sync check", "storybook changes", "need to sync", "what changed upstream", or any mention of tracking changes from storybookjs/storybook. Even casual mentions like "anything new in storybook?" should trigger this skill.
5
5
---
@@ -26,63 +26,86 @@ Analyze recent changes in the official `storybookjs/storybook` repository and id
26
26
27
27
Both webpack5 and vite upstream variants are monitored because this repo borrows patterns from both.
28
28
29
-
## Important: Upstream Commit History is Noisy
29
+
## Upstream Commit History is Noisy
30
30
31
-
The Storybook repo uses a **non-linear branching model** with frequent merge commits and automated version bumps. The bundled script already handles the most common noise:
31
+
The Storybook repo uses a non-linear branching model with frequent merge commits and automated version bumps. The bundled script filters the most common noise automatically (version bump commits via `--invert-grep`, merge commits via `--no-merges`). Some noise may still slip through — NX upgrades, CI config, non-standard version bumps, reverts that cancel out.
32
32
33
-
-**Version bump commits** (`Bump version from "X" to "Y" [skip ci]`) are filtered out automatically. These touch every package.json but contain no meaningful code changes.
34
-
-**Merge commits** are excluded via `--no-merges`. Only the actual code-change commits from feature branches are shown.
33
+
**Always judge from the actual diff.** Storybook does not consistently follow conventional commits, so commit messages are unreliable for triage decisions.
35
34
36
-
However, some noise may still slip through:
37
-
- Internal build/tooling changes (NX upgrades, CI config) that touch monitored paths
38
-
- Commits that only change `package.json` version fields without the standard "Bump version" prefix
39
-
- Reverts that cancel out earlier changes
35
+
## Sync Priority Criteria
36
+
37
+
**High** — sync soon:
38
+
- Bug fixes in logic that was adapted into storybook-rsbuild
39
+
- Security patches
40
+
- API / type / interface changes (options, preset signatures, exports)
41
+
- Breaking changes or deprecations
42
+
43
+
**Medium** — review and decide:
44
+
- New features that could benefit storybook-rsbuild users
45
+
- Significant refactoring of adapted code patterns
46
+
- Performance improvements in shared logic
47
+
48
+
**Low** — nice to know:
49
+
- Minor code quality improvements
50
+
- Added error handling or edge-case guards
51
+
- Test changes that reveal expected behavioral contracts
40
52
41
-
**Critical**: Do not rely on commit messages or file lists for triage decisions. Storybook does not consistently follow conventional commits — subjects like "Build: ...", "Fix ...", "Upgrade ...", or freeform descriptions are common. The actual diff is the only reliable source of truth for judging whether a change needs to be synced. Always read the diff.
53
+
**Skip**:
54
+
- Webpack/Vite internal plumbing with no Rsbuild parallel (e.g. webpack plugin hooks, Vite-specific HMR wiring, Vite module graph internals)
55
+
- Documentation-only changes
56
+
- CI/tooling changes internal to the Storybook repo
57
+
- Changes to `storybook/internal/*` APIs (these arrive via the `storybook` npm dependency, not by manual sync)
58
+
- Pure test file additions with no behavioral insight
59
+
- Build system changes (NX, workspace config, import rewriting) that are specific to the Storybook monorepo structure
42
60
43
61
## Workflow
44
62
45
63
### 1. Preparation
46
64
47
-
Generate the report filename first (anchored to system clock):
65
+
Generate the report filename (anchored to system clock):
-**Absolute date range**: "since 2025-12-01", "Dec 1 to Dec 20" → use `--since` / `--until`
73
+
-**Version tags**: "between v8.4.0 and v8.5.0" → use `--from` / `--to`
74
+
- If unspecified, default to `--days 30`.
57
75
58
76
**Important**: For relative date ranges, always use `--days N`. The script reads the system clock to compute exact dates, avoiding date miscalculation.
59
77
60
-
### 2. Get commit summary and plan analysis
78
+
### 2. Get commit summary and decide strategy
61
79
62
-
Fetch the commit list with diff line counts (lightweight — no full diffs):
0 commit comments