Skip to content

Commit c9d09df

Browse files
authored
WARN on CRAN w.r.t. printf (#68)
* Delete libswe.a after the fact so that unused code is not checked * Update test coverage action * prepare for release
1 parent 6746647 commit c9d09df

File tree

7 files changed

+39
-15
lines changed

7 files changed

+39
-15
lines changed

.github/workflows/recheck.yaml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
on:
2+
workflow_dispatch:
3+
inputs:
4+
which:
5+
type: choice
6+
description: Which dependents to check
7+
options:
8+
- strong
9+
- most
10+
11+
name: Reverse dependency check
12+
13+
jobs:
14+
revdep_check:
15+
name: Reverse check ${{ inputs.which }} dependents
16+
uses: r-devel/recheck/.github/workflows/recheck.yml@v1
17+
with:
18+
which: ${{ inputs.which }}

.github/workflows/test-coverage.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
1616

1717
steps:
18-
- uses: actions/checkout@v3
18+
- uses: actions/checkout@v4
1919

2020
- uses: r-lib/actions/setup-r@v2
2121
with:
@@ -32,20 +32,20 @@ jobs:
3232
covr::codecov(
3333
quiet = FALSE,
3434
clean = FALSE,
35-
install_path = file.path(Sys.getenv("RUNNER_TEMP"), "package")
35+
install_path = file.path(normalizePath(Sys.getenv("RUNNER_TEMP"), winslash = "/"), "package")
3636
)
3737
shell: Rscript {0}
3838

3939
- name: Show testthat output
4040
if: always()
4141
run: |
4242
## --------------------------------------------------------------------
43-
find ${{ runner.temp }}/package -name 'testthat.Rout*' -exec cat '{}' \; || true
43+
find '${{ runner.temp }}/package' -name 'testthat.Rout*' -exec cat '{}' \; || true
4444
shell: bash
4545

4646
- name: Upload test results
4747
if: failure()
48-
uses: actions/upload-artifact@v3
48+
uses: actions/upload-artifact@v4
4949
with:
5050
name: coverage-test-failures
51-
path: ${{ runner.temp }}/package
51+
path: ${{ runner.temp }}/package

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: swephR
22
Type: Package
33
Title: High Precision Swiss Ephemeris
4-
Version: 0.3.1.1
4+
Version: 0.3.2
55
Authors@R: c(
66
person("Ralf", "Stubner", email = "ralf.stubner@gmail.com", role = c("aut", "cre")),
77
person("Victor", "Reijs", role = "aut"),
@@ -17,7 +17,7 @@ Description: The Swiss Ephemeris (version 2.10.03) is a high precision ephemeris
1717
License: AGPL
1818
Imports: Rcpp (>= 0.12.18)
1919
LinkingTo: Rcpp
20-
RoxygenNote: 7.2.3
20+
RoxygenNote: 7.3.2
2121
Suggests:
2222
testthat,
2323
swephRdata,

NEWS.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
# NEWS for swephR
22

3-
## swephR (unpublished)
3+
## swephR (0.3.2)
44

55
* Add files seorbel.txt (fictitious bodies) and seleapsec.txt (leap seconds)
66
* Update sefstars.txt (fixed stars)
7+
* Make sure that unused code does not linger after compilation, triggering a warning on CRAN
78

89
## swephR 0.3.1
910

cran-comments.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1-
## Resubmission
2-
This is a resubmission. In this version I have:
3-
4-
* Updated the CITATION file to use bibentry()
1+
This release fixes a new warning found on CRAN. It also adds and updates some included datafiles.
52

63
## Test environments
74

8-
* local Linux install: R 4.3.0
5+
* local Linux install: R 4.4.2
96
* Ubuntu (on GHA): R oldrel, release, devel
107
* Mac OS X (on GHA): R release
118
* Windows (on GHA): R release

src/Makevars

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
PKG_LIBS=-L. -lswe
22
PKG_CPPFLAGS=-I./libswe/ -DSTRICT_R_HEADERS
33

4-
all: $(SHLIB)
4+
all: $(SHLIB) purify
5+
56
$(SHLIB): libswe.a
67

78
LIBSWE = libswe/swedate.o libswe/swehouse.o libswe/swejpl.o libswe/swemmoon.o \
89
libswe/swemplan.o libswe/sweph.o \
910
libswe/swephlib.o libswe/swecl.o libswe/swehel.o
1011
libswe.a: $(LIBSWE)
1112
$(AR) rcs libswe.a $(LIBSWE)
13+
14+
purify: $(SHLIB)
15+
@rm -rf libswe.a || true

src/Makevars.win

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
PKG_LIBS=-L. -lswe
22
PKG_CPPFLAGS=-I./libswe/ -DSTRICT_R_HEADERS
33

4-
all: $(SHLIB)
4+
all: $(SHLIB) purify
5+
56
$(SHLIB): libswe.a
67

78
LIBSWE = libswe/swedate.o libswe/swehouse.o libswe/swejpl.o libswe/swemmoon.o \
89
libswe/swemplan.o libswe/sweph.o \
910
libswe/swephlib.o libswe/swecl.o libswe/swehel.o
1011
libswe.a: $(LIBSWE)
1112
$(AR) rcs libswe.a $(LIBSWE)
13+
14+
purify: $(SHLIB)
15+
@rm -rf libswe.a || true

0 commit comments

Comments
 (0)