Skip to content

Commit 4d203bc

Browse files
committed
Merge changes from main branch
- Updated toolbar.scss to use margin: 0 on both .action-icon and .action-label - Applied snapshot updates for bs-theme-preset files
1 parent bee53e5 commit 4d203bc

File tree

5 files changed

+17
-8
lines changed

5 files changed

+17
-8
lines changed

inst/components/dist/components.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/components/scss/toolbar.scss

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@
3434
height: var(--_toolbar-btn-size); // Keep square icon and label + icon button heights consistent
3535
display: flex;
3636

37-
// Override shiny's .action-button .action-icon+.action-label margin rule for toolbar buttons
38-
.action-icon + .action-label {
39-
margin-left: 0;
37+
// Remove margins from action button elements
38+
.action-icon,
39+
.action-label {
40+
margin: 0;
4041
}
4142

4243
&.btn-default:not(.btn-primary):not(.btn-secondary):not(.btn-success):not(.btn-danger):not(.btn-warning):not(.btn-info):not(.btn-light):not(.btn-dark) {
@@ -73,6 +74,13 @@
7374
}
7475
}
7576

77+
// Add spacing between icon and label in buttons with both
78+
.bslib-toolbar-input-button[data-type="both"] {
79+
.action-icon {
80+
margin-right: 0.5ch;
81+
}
82+
}
83+
7684
// Square icon-only buttons
7785
.bslib-toolbar-input-button[data-type="icon"] {
7886
aspect-ratio: 1;

man/navset.Rd

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/_snaps/bs-theme-preset-builtin.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# builtin_bundle() / errors for unknown preset names
1+
# builtin_bundle(): errors for unknown preset names
22

33
Code
44
builtin_bundle("not-a-preset", version = "5")

tests/testthat/_snaps/bs-theme-preset.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# resolve_bs_preset() / throws an error if both `name` and `bootswatch` are provided
1+
# resolve_bs_preset(): throws an error if both `name` and `bootswatch` are provided
22

33
Code
44
resolve_bs_preset(preset = "name", bootswatch = "bootswatch")
@@ -10,7 +10,7 @@
1010
* `preset = "bootswatch"`
1111
* `bootswatch = "bootswatch"`
1212

13-
# resolve_bs_preset() / throws an error if `name` or `bootswatch` are not scalar strings
13+
# resolve_bs_preset(): throws an error if `name` or `bootswatch` are not scalar strings
1414

1515
Code
1616
resolve_bs_preset(preset = c("a", "b"))
@@ -30,7 +30,7 @@
3030
x Bad: `bootswatch = c("flatly", "darkly")`
3131
v Good: `bootswatch = "flatly"`
3232

33-
# resolve_bs_preset() / throws an error if `name` or `bootswatch` don't match existing presets
33+
# resolve_bs_preset(): throws an error if `name` or `bootswatch` don't match existing presets
3434

3535
Code
3636
resolve_bs_preset(preset = "not_a_preset", version = 4)

0 commit comments

Comments
 (0)