Merge pull request #45 from RLesur/fix-44

Author: wch

R/chromote.R

@@ -302,13 +302,6 @@ Chromote <- R6Class(
         private$sessions[[sid]] <- NULL
         session$mark_closed()
       })
-
-      # When a target crashes, raise a warning.
-      # The session cannot be closed because no session id is returned by the
-      # Inspector.targetCrashed event
-      self$protocol$Inspector$targetCrashed(function(msg) {
-        warning("Chromote has received a Inspector.targetCrashed event. This means that the ChromoteSession has probably crashed.")
-      })
     },
 
     # =========================================================================

R/chromote_session.R

@@ -85,6 +85,19 @@ ChromoteSession <- R6Class(
           private$pixel_ratio <- value$result$value
         })
 
+      # When a target crashes, raise a warning.
+      if (!is.null(self$Inspector$targetCrashed)) {
+        p <- p$
+          then(function(value) {
+            self$Inspector$targetCrashed(timeout_ = NULL, wait_ = FALSE, function(value) {
+              warning("Chromote has received a Inspector.targetCrashed event. This means that the ChromoteSession has probably crashed.")
+              # Even if no targetId nor sessionId is returned by Inspector.targetCashed
+              # mark the session as closed. This will close all sessions..
+              self$mark_closed()
+            })
+          })
+      }
+
       if (wait_) {
         self$wait_for(p)
       } else {