tidy up

t-kalinowski · t-kalinowski · commit a3244d4e8ad1 · 2021-10-20T10:14:57.000-04:00
diff --git a/R/model.R b/R/model.R
@@ -37,6 +37,8 @@ keras_model <- function(inputs, outputs = NULL, ...) {
   do.call(keras$models$Model, args)
 }
 
+# TODO: maybe warn if names are being ignored in keras_model(named_list)?
+# NOTE: keras now accepts a dict here, but it's a footgun since it doesn't check tensor.name.
 
 #' Keras Model composed of a linear stack of layers
 #'
diff --git a/tools/make-layer-wrapper.R b/tools/make-layer-wrapper.R
diff --git a/tools/test b/tools/test
@@ -10,7 +10,8 @@ export TF_CPP_MIN_LOG_LEVEL=2
   # 3 = INFO, WARNING, and ERROR messages are not printed
 
 
-for i in 2.{1..6} nightly
+for i in 2.{4..7} nightly
+# for i in 2.{1..3}
 do
 TMPDIR="/tmp/r-keras-tests/tf-$i/"
 mkdir -p $TMPDIR

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,8 @@ keras_model <- function(inputs, outputs = NULL, ...) {`
`37`	`37`	`do.call(keras$models$Model, args)`
`38`	`38`	`}`
`39`	`39`
	`40`	`+# TODO: maybe warn if names are being ignored in keras_model(named_list)?`
	`41`	`+# NOTE: keras now accepts a dict here, but it's a footgun since it doesn't check tensor.name.`
`40`	`42`
`41`	`43`	`#' Keras Model composed of a linear stack of layers`
`42`	`44`	`#'`