Fix warning from tfruns::training_run() being unable to log optimizer learning rate.

t-kalinowski · t-kalinowski · commit a965e043c72c · 2024-07-03T11:44:18.000-04:00
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,8 @@
 
 - `keras_shape` objects (as returned by `keras3::shape()`) gain `==` and `!=` methods.
 
+- Fixed warning from `tfruns::training_run()` being unable to log optimizer learning rate.
+
 - Added compatibility with Keras v3.4.1 (no R user facing changes).
 
 User facing changes with upstream Keras v3.4.0:
diff --git a/R/zzz-metrics-callback.R b/R/zzz-metrics-callback.R
@@ -119,7 +119,7 @@ callback_view_metrics <- Callback(
         optimizer <- model$optimizer
         if (!is.null(optimizer)) {
           model_info$optimizer <- py_str(optimizer)
-          model_info$learning_rate <- as.double(optimizer$lr)
+          model_info$learning_rate <- as.double(optimizer$learning_rate)
         }
         tfruns::write_run_metadata("properties", model_info)
       }, error = function(e) {

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ callback_view_metrics <- Callback(`
`119`	`119`	`optimizer <- model$optimizer`
`120`	`120`	`if (!is.null(optimizer)) {`
`121`	`121`	`model_info$optimizer <- py_str(optimizer)`
`122`		`- model_info$learning_rate <- as.double(optimizer$lr)`
	`122`	`+ model_info$learning_rate <- as.double(optimizer$learning_rate)`
`123`	`123`	`}`
`124`	`124`	`tfruns::write_run_metadata("properties", model_info)`
`125`	`125`	`}, error = function(e) {`