Skip to content

Commit c11be46

Browse files
committed
update r_to_py.keras_layer_wrapper() method formals
per request via email from CRAN. New R CMD check warning on R devel: checking S3 generic/method consistency ... WARNING r_to_py: function(x, convert) r_to_py.keras_layer_wrapper: function(fn, convert) See section ‘Generic functions and methods’ in the ‘Writing R Extensions’ manual.
1 parent bc8ddf3 commit c11be46

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

NEWS.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# keras (development version)
22

3+
- Update S3 method formals per new CRAN requirement (`r_to_py.keras_layer_wrapper()`)
4+
35
# keras 2.11.0
46

57
- Default TensorFlow version installed by `install_keras()` is now 2.11.

R/layer-custom.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,8 @@ create_layer_wrapper <- function(Layer, modifiers = NULL, convert = TRUE) {
244244

245245

246246
#' @export
247-
r_to_py.keras_layer_wrapper <- function(fn, convert = FALSE) {
248-
layer <- attr(fn, "Layer", TRUE)
247+
r_to_py.keras_layer_wrapper <- function(x, convert = FALSE) {
248+
layer <- attr(x, "Layer", TRUE)
249249
if (!inherits(layer, "python.builtin.type"))
250250
layer <- r_to_py(layer, convert)
251251
layer

0 commit comments

Comments
 (0)