Merge pull request #837 from rstudio/remove-retired-dependencies

Remove outdated dependencies; use testthat-3e

Author: jcheng5

DESCRIPTION

@@ -43,7 +43,7 @@ Imports:
     methods,
     png,
     RColorBrewer,
-    raster,
+    raster (>= 3.6.3),
     scales (>= 1.0.0),
     sp,
     stats,
@@ -54,14 +54,13 @@ Suggests:
     maps,
     sf (>= 0.9-6),
     shiny,
-    rgdal,
-    rgeos,
     R6,
     RJSONIO,
     purrr,
     testthat (>= 3.0.0),
     s2,
     terra
-RoxygenNote: 7.2.1
+RoxygenNote: 7.2.3
 Encoding: UTF-8
 LazyData: true
+Config/testthat/edition: 3

NEWS

@@ -8,6 +8,8 @@ BUG FIXES and IMPROVEMENTS
 
 * Use `xfun::base64_uri()` for base64 encoding instead of **markdown** and **base64enc**. (#823)
 
+* Remove dependencies on rgdal and rgeos. (#837)
+
 leaflet 2.1.1
 --------------------------------------------------------------------------------
 

R/layers.R

@@ -232,10 +232,9 @@ epsg3857 <- "+proj=merc +a=6378137 +b=6378137 +lat_ts=0.0 +lon_0=0.0 +x_0=0.0 +y
 #' values(r) <- matrix(1:900, nrow(r), ncol(r), byrow = TRUE)
 #' crs(r) <- CRS("+init=epsg:4326")
 #'
-#' if (requireNamespace("rgdal")) {
-#'   leaflet() %>% addTiles() %>%
-#'     addRasterImage(r, colors = "Spectral", opacity = 0.8)
-#' }}
+#' leaflet() %>% addTiles() %>%
+#'   addRasterImage(r, colors = "Spectral", opacity = 0.8)
+#' }
 #' @export
 addRasterImage <- function(
   map,

R/normalize-sp.R

@@ -90,11 +90,29 @@ to_multipolygon_list.SpatialPolygons <- function(pgons) {
 to_multipolygon.Polygons <- function(pgons) {
   if (length(pgons@Polygons) > 1) {
     # If Polygons contains more than one Polygon, then we may be dealing with
-    # a polygon with holes or a multipolygon (potentially with holes). Use
-    # createPolygonsComment to validate and determine what the situation is.
+    # a polygon with holes or a multipolygon (potentially with holes). We used
+    # to use rgeos::createPolygonsComment, but rgeos has been deprecated, so now
+    # we use sf.
     comment <- comment(pgons)
-    if (is.null(comment) || comment == "FALSE")
-      comment <- rgeos::createPolygonsComment(pgons)
+    if (is.null(comment) || comment == "FALSE") {
+      if (any(vapply(pgons@Polygons, methods::slot, logical(1), "hole"))) {
+        if (!require("sf")) {
+          stop("You attempted to use an sp Polygons object that is missing hole ",
+            "information. Leaflet can use the {sf} package to infer hole ",
+            "assignments, but it is not installed. Please install the {sf} ",
+            "package, and try the operation again.")
+        } else if (packageVersion("sf") < "1.0.10") {
+          stop("You attempted to use an sp Polygons object that is missing hole ",
+            "information. Leaflet can use the {sf} package to infer hole ",
+            "assignments, but only with sf v1.0-10 and above. Please upgrade ",
+            "the {sf} package, and try the operation again.")
+        }
+        x <- to_multipolygon_list(sf::st_geometry(sf::st_as_sf(SpatialPolygons(list(pgons)))))
+        return(x[[1]])
+      } else {
+        comment <- paste(collapse = " ", rep_len("0", length(pgons@Polygons)))
+      }
+    }
     pstatus <- as.integer(strsplit(comment, " ")[[1]])
     lapply(which(pstatus == 0L), function(index) {
       # Return a list of rings, exterior first

R/staticimports.R

@@ -81,11 +81,9 @@ system_file <- function(..., package = "base") {
   normalizePath(files, winslash = "/")
 }
 
-# A wrapper for `system.file()`, which caches the results, because
-# `system.file()` can be slow. Note that because of caching, if
-# `system_file_cached()` is called on a package that isn't installed, then the
-# package is installed, and then `system_file_cached()` is called again, it will
-# still return "".
+# A wrapper for `system.file()`, which caches the package path because
+# `system.file()` can be slow. If a package is not installed, the result won't
+# be cached.
 system_file_cached <- local({
   pkg_dir_cache <- character()
 
@@ -97,7 +95,9 @@ system_file_cached <- local({
     not_cached <- is.na(match(package, names(pkg_dir_cache)))
     if (not_cached) {
       pkg_dir <- system.file(package = package)
-      pkg_dir_cache[[package]] <<- pkg_dir
+      if (nzchar(pkg_dir)) {
+        pkg_dir_cache[[package]] <<- pkg_dir
+      }
     } else {
       pkg_dir <- pkg_dir_cache[[package]]
     }

docs/raster.Rmd

@@ -4,37 +4,31 @@ pagetitle: Leaflet for R - Raster Images
 
 ## Raster Images
 
-Two-dimensional `RasterLayer` objects (from the [`raster` package](http://CRAN.R-project.org/package=raster)) can be turned into images and added to Leaflet maps using the `addRasterImage` function.
+Two-dimensional `SpatRaster` objects (from the [`terra` package](https://CRAN.R-project.org/package=terra)) or `RasterLayer` objects (from the [`raster` package](https://CRAN.R-project.org/package=raster)) can be turned into images and added to Leaflet maps using the `addRasterImage` function.
 
-The `addRasterImage` function works by projecting the `RasterLayer` object to [EPSG:3857](http://spatialreference.org/ref/sr-org/7483/) and encoding each cell to an RGBA color, to produce a PNG image. That image is then embedded in the map widget.
+The `addRasterImage` function works by projecting the `SpatRaster` or `RasterLayer` object to [EPSG:3857](http://spatialreference.org/ref/sr-org/7483/) and encoding each cell to an RGBA color, to produce a PNG image. That image is then embedded in the map widget.
 
-It's important that the `RasterLayer` object is tagged with a proper coordinate reference system. Many raster files contain this information, but some do not. Here is how you'd tag a raster layer object "`r`" which contains WGS84 data:
+It's important that the raster object is tagged with a proper coordinate reference system. Many raster files contain this information, but some do not. Here is how you'd tag a raster object "`r`" which contains WGS84 data:
 
 ```r
-crs(r) <- sp::CRS("+proj=longlat +ellps=WGS84 +datum=WGS84 +no_defs")
+crs(r) <- "+proj=longlat +datum=WGS84"
 ```
 
 ### Large Raster Warning
 
 Because the `addRasterImage` function embeds the image in the map widget, it will increase the size of the generated HTML proportionally. In order to avoid unacceptable download times and memory usage, `addRasterImage` will error when the PNG is beyond the size indicated by the `maxBytes` argument (defaults to 4 megabytes).
 
-If you have a large raster layer, you can provide a larger number of bytes and see how it goes, or use `raster::resample` or `raster::aggregate` to decrease the number of cells.
+If you have a large raster layer, you can provide a larger number of bytes and see how it goes, or use `terra::resample`, `raster::resample`, or `raster::aggregate` to decrease the number of cells.
 
 ### Projection Performance
 
-The `addRasterImage` function projects using `raster::projectRaster`, which can take a while on all but the smallest rasters. To improve performance, the first thing to do is install a new version of `raster`; version 2.4 includes optimizations that speed up bilinear projection by about 10X. This version has not yet been released to CRAN at the time of this writing (June 17, 2015) but can be installed directly from R-Forge:
-
-```r
-install.packages('raster', repos = 'http://r-forge.r-project.org/', type = 'source')
-```
-
-If you have a large raster layer or expect to call `addRasterImage` on the same raster layer many times, you can perform the [EPSG:3857](http://spatialreference.org/ref/sr-org/7483/) projection yourself (either using `leaflet::projectRasterForLeaflet` or using another GIS library or program) and call `addRasterImage` with `project = FALSE`.
+The `addRasterImage` function projects using `terra::project` or `raster::projectRaster`, which can take a while on all but the smallest rasters. If you have a large raster layer or expect to call `addRasterImage` on the same raster layer many times, you can perform the [EPSG:3857](http://spatialreference.org/ref/sr-org/7483/) projection yourself (either using `leaflet::projectRasterForLeaflet` or using another GIS library or program) and call `addRasterImage` with `project = FALSE`.
 
 Be sure that your pre-projected raster layer is tagged with an accurate extent and CRS, as these values are still needed to place the image in the proper position on the map.
 
 ### Coloring
 
-In order to render the `RasterLayer` as an image, each cell value must be converted to an RGB(A) color. You can specify the color scale using the `colors` argument, which accepts a variety of color specifications:
+In order to render the raster object as an image, each cell value must be converted to an RGB(A) color. You can specify the color scale using the `colors` argument, which accepts a variety of color specifications:
 
 * The name of a [Color Brewer 2](http://colorbrewer2.org/) palette. If no `colors` argument is provided, then `"Spectral"` is the default.
 * A vector that represents the ordered list of colors to map to the data. Any color specification that is accepted by `grDevices::col2rgb` can be used, including `"#RRGGBB"` and `"#RRGGBBAA"` forms. Example: `colors = c("#E0F3DB", "#A8DDB5", "#43A2CA")`.

man/addRasterImage.Rd

@@ -0,0 +1,53 @@
+# normalize
+
+    [[1]]
+    [[1]][[1]]
+    [[1]][[1]][[1]]
+      lng lat
+    1  -1   1
+    2   1   1
+    3   1  -1
+    4  -1  -1
+    5  -1   1
+    
+    [[1]][[1]][[2]]
+       lng  lat
+    1 -0.5 -0.5
+    2  0.5 -0.5
+    3  0.5  0.5
+    4 -0.5  0.5
+    5 -0.5 -0.5
+    
+    
+    [[1]][[2]]
+    [[1]][[2]][[1]]
+      lng lat
+    1   4   6
+    2   6   6
+    3   6   4
+    4   4   4
+    5   4   6
+    
+    [[1]][[2]][[2]]
+       lng  lat
+    1 4.05 4.05
+    2 4.45 4.05
+    3 4.45 4.45
+    4 4.05 4.45
+    5 4.05 4.05
+    
+    [[1]][[2]][[3]]
+      lng lat
+    1 4.5 4.5
+    2 5.5 4.5
+    3 5.5 5.5
+    4 4.5 5.5
+    5 4.5 4.5
+    
+    
+    
+    attr(,"bbox")
+        [,1] [,2]
+    lng   -1    6
+    lat   -1    6
+

tests/testthat/_snaps/normalize-2.md

@@ -0,0 +1,17 @@
+create_square <- function(width = 2, lng = 0, lat = 0, hole = FALSE, type = Polygon) {
+  lngs <- c(lng - width / 2, lng + width / 2, lng + width / 2, lng - width / 2)
+  lats <- c(lat + width / 2, lat + width / 2, lat - width / 2, lat - width / 2)
+
+  if (hole) {
+    lngs <- rev(lngs)
+    lats <- rev(lats)
+  }
+
+  if ("hole" %in% names(formals(type))) {
+    type(cbind(lng = lngs, lat = lats), hole = hole)
+  } else {
+    type(cbind(lng = lngs, lat = lats))
+  }
+}
+
+

tests/testthat/helper.R

@@ -1,5 +1,3 @@
-context("colors")
-
 # Like expect_warning, but returns the result of the expr
 with_warning <- function(expr) {
   expect_warning(result <- force(expr))