Addressed code reivew comments from #293

Author: bhaskarvk

R/plugin-graticule.R

@@ -34,12 +34,12 @@ addGraticule <- function(
 ) {
   map$dependencies <- c(map$dependencies, leafletGraticuleDependencies())
   invokeMethod(
-    map
-    , getMapData(map)
-    , 'addGraticule'
-    , interval
-    , style
-    , layerId
-    , group
+    map,
+    getMapData(map),
+    'addGraticule',
+    interval,
+    style,
+    layerId,
+    group
   )
 }

R/plugin-minimap.R

@@ -16,7 +16,6 @@ leafletMiniMapDependencies <- function() {
 #' \url{https://github.com/Norkart/Leaflet-MiniMap}
 #'
 #' @param map a map widget object
-#' @param tiles URL for tiles or one of the pre-defined providers.
 #' @param position The standard Leaflet.Control position parameter,
 #'    used like all the other controls.
 #' Defaults to 'bottomright'.
@@ -52,6 +51,7 @@ leafletMiniMapDependencies <- function() {
 #'    a Path.Options (\url{http://leafletjs.com/reference.html#path-options}) object.
 #'    (Clickable will always be overridden and set to false.)
 #' @param strings Overrides the default strings allowing for translation.
+#' @param tiles URL for tiles or one of the pre-defined providers.
 #' @param mapOptions Sets Leaflet options for the MiniMap map.
 #'    It does not override the MiniMap default map options but extends them.
 #' @examples
@@ -65,7 +65,6 @@ leafletMiniMapDependencies <- function() {
 #' @export
 addMiniMap <- function(
   map,
-  tiles = NULL,
   position = 'bottomright',
   width = 150,
   height = 150,
@@ -82,6 +81,7 @@ addMiniMap <- function(
   shadowRectOptions = list(color= '#000000', weight= 1, clickable= FALSE,
                            opacity= 0, fillOpacity= 0),
   strings = list(hideText= 'Hide MiniMap', showText= 'Show MiniMap'),
+  tiles = NULL,
   mapOptions = list()
 ) {
 

inst/htmlwidgets/plugins/Leaflet-MiniMap/Minimap-binding.js

@@ -1,8 +1,9 @@
-  LeafletWidget.methods.addMiniMap = function(tilesURL, tilesProvider, position,
+LeafletWidget.methods.addMiniMap =
+  function(tilesURL, tilesProvider, position,
   width, height, collapsedWidth, collapsedHeight , zoomLevelOffset,
   zoomLevelFixed, centerFixed, zoomAnimation , toggleDisplay, autoToggleDisplay,
-  minimized, aimingRectOptions,
-  shadowRectOptions, strings, mapOptions) {
+  minimized, aimingRectOptions, shadowRectOptions, strings, mapOptions) {
+
     (function() {
       if(this.minimap) {
         this.minimap.removeFrom( this );
@@ -19,24 +20,24 @@
         layer = new L.tileLayer(tilesURL);
       }
 
-        this.minimap = new L.Control.MiniMap(layer, {
-          position: position,
-          width: width,
-          height: height,
-          collapsedWidth: collapsedWidth,
-          collapsedHeight: collapsedWidth,
-          zoomLevelOffset: zoomLevelOffset,
-          zoomLevelFixed: zoomLevelFixed,
-          centerFixed: centerFixed,
-          zoomAnimation: zoomAnimation,
-          toggleDisplay: toggleDisplay,
-          autoToggleDisplay: autoToggleDisplay,
-          minimized: minimized,
-          aimingRectOptions: aimingRectOptions,
-          shadowRectOptions: shadowRectOptions,
-          strings: strings,
-          mapOptions: mapOptions
-        });
-        this.minimap.addTo(this);
+      this.minimap = new L.Control.MiniMap(layer, {
+        position: position,
+        width: width,
+        height: height,
+        collapsedWidth: collapsedWidth,
+        collapsedHeight: collapsedWidth,
+        zoomLevelOffset: zoomLevelOffset,
+        zoomLevelFixed: zoomLevelFixed,
+        centerFixed: centerFixed,
+        zoomAnimation: zoomAnimation,
+        toggleDisplay: toggleDisplay,
+        autoToggleDisplay: autoToggleDisplay,
+        minimized: minimized,
+        aimingRectOptions: aimingRectOptions,
+        shadowRectOptions: shadowRectOptions,
+        strings: strings,
+        mapOptions: mapOptions
+      });
+      this.minimap.addTo(this);
     }).call(this);
   };