Skip to content

Commit e61c81f

Browse files
authored
require scales >= 1.0.0 and fix broken test (#578)
* require scales >= 1.0.0 and fix broken test * add pr number
1 parent 25bbc09 commit e61c81f

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

DESCRIPTION

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Imports:
4747
png,
4848
RColorBrewer,
4949
raster,
50-
scales (>= 0.2.5),
50+
scales (>= 1.0.0),
5151
sp,
5252
stats,
5353
viridis (>= 0.5.1)
@@ -64,4 +64,5 @@ Suggests:
6464
purrr,
6565
testthat
6666
RoxygenNote: 6.0.1
67+
Encoding: UTF-8
6768
LazyData: true

NEWS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ leaflet 2.0.1.9000
44
BUG FIXES and IMPROVEMENTS
55
* Require viridis >= 0.5.1 to avoid namespace issues with viridisLite (#557)
66
* Fixed broken mouse events after using leaflet-search from leaflet.extras within shiny applications (#563)
7+
* Require scales >= 1.0.0 to avoid exact color matching issues (#578)
78

89

910

tests/testit/test-colors.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ assert(
3737
colorNumeric(colorRamp(bw), NULL)(c(0, 0.5, 1))
3838
),
3939
identical(
40-
c("#000000FF", "#777777FF", "#FFFFFFFF", "#FFFFFF00", "blue"),
40+
c("#000000", "#777777", "#FFFFFF", "#FFFFFF00", "blue"),
4141
colorNumeric(c(bw, "#FFFFFF00"), NULL, na.color = "blue", alpha = TRUE)(c(0, 0.25, 0.5, 1, NA))
4242
)
4343
)

0 commit comments

Comments
 (0)