Skip to content

Commit c48de8c

Browse files
committed
revert 7878384 since it does not really help
1 parent b2fd54b commit c48de8c

File tree

3 files changed

+1
-7
lines changed

3 files changed

+1
-7
lines changed

NEWS.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010

1111
- Created an option `pagedown.chrome.log` to ease `chrome_print()` debugging: when set to `TRUE`, the logs of Chrome are saved in the working directory.
1212

13-
- In `chrome_print()`, set a timeout when R tries to detect headless Chrome.
14-
1513
- Added support for Sass files with `.scss` and `.sass` extension (thanks, @felipecrp, #244).
1614

1715
## BUG FIXES

R/chrome.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ is_remote_protocol_ok = function(debug_port,
347347
sleep_time = getOption("pagedown.remote.sleeptime", 0.5)
348348
if (verbose >= 1) message('Trying to find headless Chrome in ', max_attempts, ' attempts')
349349
for (i in seq_len(max_attempts)) {
350-
remote_protocol = xfun::Rscript_call('pagedown:::try_read_json', list(url), timeout = 10)
350+
remote_protocol = tryCatch(suppressWarnings(jsonlite::read_json(url)), error = function(e) NULL)
351351
if (!is.null(remote_protocol)) {
352352
if (verbose >= 1) message('Headless Chrome found at attempt ', i)
353353
break

R/utils.R

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,3 @@ run_servr = function() {
3838
# see https://github.com/rstudio/httpuv/issues/250
3939
later::with_loop(later::global_loop(), httpuv::service(NA))
4040
}
41-
42-
try_read_json = function(url) {
43-
tryCatch(suppressWarnings(jsonlite::read_json(url)), error = function(e) NULL)
44-
}

0 commit comments

Comments
 (0)