fix #345: also consider unnumbered headings when adding hr below them

yihui · yihui · commit f47e3a6dad08 · 2026-03-23T16:48:46.000-05:00
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: pagedown
 Type: Package
 Title: Paginate the HTML Output of R Markdown with CSS for Print
-Version: 0.23.1
+Version: 0.23.2
 Authors@R: c(
   person("Yihui", "Xie", role = c("aut", "cre"), email = "xie@yihui.name", comment = c(ORCID = "0000-0003-0645-5666")),
   person("Romain", "Lesur", role = c("aut", "cph"), comment = c(ORCID = "0000-0002-0721-5595")),
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # CHANGES IN pagedown VERSION 0.24
 
+- Fixed the bug that horizontal lines are not added below unnumbered h1 headers in the `poster_jacobs` format (thanks, @djsimmonds, #345).
 
 # CHANGES IN pagedown VERSION 0.23
 
diff --git a/inst/resources/html/poster-jacobs.html b/inst/resources/html/poster-jacobs.html
@@ -45,7 +45,7 @@ <h2 class="institute">$institute$</h2>
 // add appropriate classes to h1 and its parent div
 document.querySelectorAll('h1').forEach((el, i) => {
   const p = el.parentNode;
-  if (p.className.match(/^section level1$$/)) {
+  if (p.className.match(/^section level1( unnumbered)?$$/)) {
     el.append(document.createElement('hr'));
   }
   p.classList.add(`section-$${i + 1}`);

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`# CHANGES IN pagedown VERSION 0.24`
`2`	`2`
	`3`	+- Fixed the bug that horizontal lines are not added below unnumbered h1 headers in the `poster_jacobs` format (thanks, @djsimmonds, #345).
`3`	`4`
`4`	`5`	`# CHANGES IN pagedown VERSION 0.23`
`5`	`6`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ <h2 class="institute">$institute$</h2>`
`45`	`45`	`// add appropriate classes to h1 and its parent div`
`46`	`46`	`document.querySelectorAll('h1').forEach((el, i) => {`
`47`	`47`	`const p = el.parentNode;`
`48`		`- if (p.className.match(/^section level1$$/)) {`
	`48`	`+ if (p.className.match(/^section level1( unnumbered)?$$/)) {`
`49`	`49`	`el.append(document.createElement('hr'));`
`50`	`50`	`}`
`51`	`51`	p.classList.add(`section-$${i + 1}`);