tests: update tests and snapshots

Author: machow

pins/tests/_snapshots/test_board_pin_write_rsc_index_html/data.txt

@@ -1,7 +1,7 @@
 api_version: 1
 created: 20200113T235859Z
 description: some description
-file: test_rsc_pin
+file: test_rsc_pin.csv
 file_size: 23
 pin_hash: 60d4c36d7138cb6c
 title: some pin

pins/tests/_snapshots/test_board_pin_write_rsc_index_html/index.html

@@ -38,13 +38,13 @@ <h3>derek/test_rsc_pin</h3>
          <b>API:</b> v1
        </p>
        <p>some description</p>
-       <p>Download data: <a href="test_rsc_pin">test_rsc_pin</a></p>
+       <p>Download data: <a href="test_rsc_pin.csv">test_rsc_pin.csv</a></p>
        <details>
          <summary>Raw metadata</summary>
          <pre>api_version: 1
 created: 20200113T235859Z
 description: some description
-file: test_rsc_pin
+file: test_rsc_pin.csv
 file_size: 23
 pin_hash: 60d4c36d7138cb6c
 title: some pin

pins/tests/_snapshots/test_board_pin_write_rsc_index_html/test_rsc_pin renamed to pins/tests/_snapshots/test_board_pin_write_rsc_index_html/test_rsc_pin.csv

@@ -47,10 +47,10 @@ def test_board_pin_write_prepare_pin(board, tmp_dir2):
     meta = board.prepare_pin_version(
         str(tmp_dir2), df, "df_csv", title=None, type="csv"
     )
-    assert meta.file == "df_csv"
+    assert meta.file == "df_csv.csv"
     assert (tmp_dir2 / "data.txt").exists()
-    assert (tmp_dir2 / "df_csv").exists()
-    assert not (tmp_dir2 / "df_csv").is_dir()
+    assert (tmp_dir2 / "df_csv.csv").exists()
+    assert not (tmp_dir2 / "df_csv.csv").is_dir()
 
 
 def test_board_pin_write_roundtrip(board):

pins/tests/test_boards.py

@@ -39,9 +39,10 @@ def test_meta_to_pin_dict_roundtrip(meta):
 
 def test_meta_factory_create():
     mf = MetaFactory()
-    with tempfile.NamedTemporaryFile() as tmp_file:
-        tmp_file.file.write(b"test")
-        tmp_file.file.close()
+    with tempfile.TemporaryDirectory() as tmp_dir:
+        tmp_file = f"{tmp_dir}/some_name"
+        with open(tmp_file, "wb") as f:
+            f.write(b"test")
 
         kwargs = {
             "title": "some title",
@@ -51,7 +52,7 @@ def test_meta_factory_create():
             "name": "some_name",
         }
 
-        meta = mf.create(tmp_file.name, **kwargs)
+        meta = mf.create(tmp_dir, tmp_file, **kwargs)
 
         # test that kwargs are passed through ----
         for k, v in kwargs.items():