refactor: change print statements to logging

Author: machow

pins/boards.py

@@ -1,3 +1,4 @@
+import logging
 import tempfile
 import shutil
 import inspect
@@ -390,9 +391,9 @@ def pin_versions_prune(
         # TODO(question): how to pin_inform? Log or warning?
         if to_delete:
             str_vers = ", ".join([v.version for v in to_delete])
-            print(f"Deleting versions: {str_vers}.")
+            logging.info(f"Deleting versions: {str_vers}.")
         if not to_delete:
-            print("No old versions to delete")
+            logging.info("No old versions to delete")
 
         for version in to_delete:
             self.pin_version_delete(name, version.version)

pins/cache.py

@@ -1,4 +1,5 @@
 import humanize
+import logging
 import os
 import time
 import shutil
@@ -64,7 +65,7 @@ def _make_local_details(self, path):
         # note that this is called in ._open(), at the point it's known the file
         # will be cached
         fn = super()._make_local_details(path)
-        print(f"cache file: {fn}")
+        logging.info(f"cache file: {fn}")
         Path(fn).parent.mkdir(parents=True, exist_ok=True)
 
         return fn
@@ -199,7 +200,7 @@ def prune(self, days=30):
             for path in to_prune:
                 delete_version(to_prune)
 
-        print("Skipping cache deletion")
+        logging.info("Skipping cache deletion")
 
 
 def delete_version(path: "str | Path"):
@@ -212,7 +213,7 @@ def disk_usage(path):
 
 
 def prompt_cache_prune(to_prune, size) -> bool:
-    print(to_prune)
+    logging.info(f"Pruning items: {to_prune}")
     human_size = humanize.naturalsize(size, binary=True)
     resp = input(f"Delete {len(to_prune)} pin versions, freeing {human_size}?")
     return resp == "yes"

pins/meta.py

@@ -112,8 +112,8 @@ def to_pin_yaml(self, f: Optional[IOBase] = None) -> "str | None":
 class MetaV0:
     file: Union[str, Sequence[str]]
     type: str
+    description: "str | None"
 
-    description: str
     name: str
 
     version: VersionRaw
@@ -134,9 +134,10 @@ def to_dict(self):
     @classmethod
     def from_pin_dict(cls, data, pin_name, version) -> "MetaV0":
         # could infer from dataclasses.fields(), but seems excessive.
-        req_fields = {"type", "description", "name"}
+        req_fields = {"type", "description"}
 
-        req_inputs = {k: v for k, v in data.items() if k in req_fields}
+        # Note that we need to .get(), since fields may not be in metadata
+        req_inputs = {k: data.get(k) for k in req_fields}
         req_inputs["file"] = data["path"]
 
         return cls(**req_inputs, name=pin_name, original_fields=data, version=version)

pins/rsconnect/api.py

@@ -1,3 +1,4 @@
+import logging
 import os
 import requests
 import tempfile
@@ -246,13 +247,12 @@ def walk_paginated_offsets(self, f_query, endpoint, method, params=None, **kwarg
         all_results.extend(data["results"])
 
         while data["results"]:
-            print("FETCHING")
+            logging.info(f"RSConnect API {method}: {endpoint}")
             page_kwargs = {"page_number": data["current_page"] + 1}
             new_params = {**params, **page_kwargs}
             data = f_query(endpoint, method, params=new_params)
 
             all_results.extend(data["results"])
-            print(data["results"])
 
         return all_results