fix(rsc): allow pin_write to use full name

Author: machow

pins/boards.py

@@ -736,13 +736,15 @@ def user_name(self):
         user = self.fs.api.get_user()
         return user["username"]
 
-    def prepare_pin_version(self, pin_dir_path, x, *args, **kwargs):
-        from jinja2 import Environment
+    def prepare_pin_version(self, pin_dir_path, x, name: "str | None", *args, **kwargs):
 
-        env = Environment()
-        template = env.from_string(self.html_template.read_text())
+        # RSC pin names can have form <user_name>/<name>, but this will try to
+        # create the object in a directory named <user_name>. So we grab just
+        # the <name> part.
+        if "/" in name:
+            name = name.split("/")[-1]
 
-        meta = super().prepare_pin_version(pin_dir_path, x, *args, **kwargs)
+        meta = super().prepare_pin_version(pin_dir_path, x, name, *args, **kwargs)
 
         # copy in files needed by index.html ----------------------------------
         crnt_files = set([meta.file] if isinstance(meta.file, str) else meta.file)
@@ -788,6 +790,13 @@ def prepare_pin_version(self, pin_dir_path, x, *args, **kwargs):
             # TODO(compat): set display none in index.html
             context["data_preview"] = json.dumps({})
 
+        # render html template ----
+
+        from jinja2 import Environment
+
+        env = Environment()
+        template = env.from_string(self.html_template.read_text())
+
         rendered = template.render(context)
         (Path(pin_dir_path) / "index.html").write_text(rendered)
 

pins/tests/test_boards.py

@@ -268,11 +268,10 @@ def test_board_pin_search_name(board, df, search, matches):
 from pins.boards import BoardRsConnect  # noqa
 
 
-@pytest.mark.xfail
 @pytest.mark.fs_rsc
 def test_board_pin_write_rsc_full_name(df, fs_short):  # noqa
     board_susan = BoardRsConnect("", fs_short)
-    board_susan.pin_write(df, "susan/df", type="csv")
+    board_susan.pin_write(df, "susan/some_df", type="csv")
 
 
 @pytest.mark.fs_rsc