Skip to content

Commit 3907a91

Browse files
authored
feat: cloud board_deparse (#157)
1 parent d627844 commit 3907a91

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

pins/constructors.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ def board_deparse(board: BaseBoard):
5858
return f"board_rsconnect(server_url={repr(url)}{allow_pickle})"
5959
elif prot == "file":
6060
return f"board_folder({repr(board.board)}{allow_pickle})"
61+
elif prot == ["s3", "s3a"]:
62+
return f"board_s3({repr(board.board)}{allow_pickle})"
63+
elif prot == "abfs":
64+
return f"board_azure({repr(board.board)}{allow_pickle})"
65+
elif prot == ("gcs", "gs"):
66+
return f"board_gcs({repr(board.board)}{allow_pickle})"
6167
else:
6268
raise NotImplementedError(
6369
f"board deparsing currently not supported for protocol: {prot}"

pins/tests/test_constructors.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,6 @@ def test_board_constructor_folder(tmp_dir2, df):
268268

269269
def test_board_deparse(board):
270270
prot = board.fs.protocol
271-
if prot not in ["rsc", "file"]:
272-
# not implemented for other boards
273-
pytest.xfail()
274271

275272
with rm_env("CONNECT_API_KEY"):
276273
if prot == "rsc":

0 commit comments

Comments
 (0)