fix(rsconnect): ensure meta name is always full pin name

Author: machow

pins/boards.py

@@ -245,18 +245,29 @@ def pin_write(
             A date to store in the Meta.created field. This field may be used as
             part of the pin version name.
         """
+
+        pin_name = self.path_to_pin(name)
+
         # TODO(docs): describe options for type argument
         # TODO(docs): elaborate on default behavior for versioned parameter
         # TODO(compat): python pins added a created parameter above
         with tempfile.TemporaryDirectory() as tmp_dir:
             # create all pin data (e.g. data.txt, save object)
             meta = self.prepare_pin_version(
-                tmp_dir, x, name, type, title, description, metadata, versioned, created
+                tmp_dir,
+                x,
+                pin_name,
+                type,
+                title,
+                description,
+                metadata,
+                versioned,
+                created,
             )
 
             # move pin to destination ----
             # create pin version folder
-            dst_pin_path = self.construct_path([self.path_to_pin(name)])
+            dst_pin_path = self.construct_path([pin_name])
             dst_version_path = self.path_to_deploy_version(name, meta.version.version)
 
             try:
@@ -773,6 +784,7 @@ def prepare_pin_version(self, pin_dir_path, x, name: "str | None", *args, **kwar
         # TODO(compat): py pins always uses the short name, R pins uses w/e the
         # user passed, but guessing people want the long name?
         meta = super().prepare_pin_version(pin_dir_path, x, short_name, *args, **kwargs)
+        meta.name = name
 
         # copy in files needed by index.html ----------------------------------
         crnt_files = set([meta.file] if isinstance(meta.file, str) else meta.file)

pins/tests/test_boards.py

@@ -301,15 +301,20 @@ def test_board_pin_search_name(board, df, search, matches):
 
 
 @pytest.mark.fs_rsc
-def test_board_pin_write_rsc_full_name(df, fs_short):  # noqa
-    board_susan = BoardRsConnect("", fs_short)
-    board_susan.pin_write(df, "susan/some_df", type="csv")
+@pytest.fixture
+def board_short(fs_short):  # noqa
+    board_short = BoardRsConnect("", fs_short)
+    return board_short
+
+
+@pytest.mark.fs_rsc
+def test_board_pin_write_rsc_full_name(df, board_short):  # noqa
+    board_short.pin_write(df, "susan/some_df", type="csv")
 
 
 @pytest.mark.fs_rsc
-def test_board_pin_search_admin_user(df, fs_short, fs_admin):  # noqa
-    board_susan = BoardRsConnect("", fs_short)
-    board_susan.pin_write(df, "some_df", type="csv")
+def test_board_pin_search_admin_user(df, board_short, fs_admin):  # noqa
+    board_short.pin_write(df, "some_df", type="csv")
 
     board_admin = BoardRsConnect("", fs_admin)
     search_res = board_admin.pin_search("susan", as_df=False)
@@ -324,6 +329,23 @@ def test_board_pin_search_admin_user(df, fs_short, fs_admin):  # noqa
     assert isinstance(search_res2.loc[0, "meta"], MetaRaw)
 
 
+@pytest.mark.fs_rsc
+def test_board_pin_meta_is_full_name(df, board_short):
+    meta = board_short.pin_write(df, "susan/some_df", type="csv")
+
+    assert meta.name == "susan/some_df"
+
+    meta2 = board_short.pin_write(df, "some_df", type="csv")
+    assert meta2.name == "susan/some_df"
+
+    meta3 = board_short.pin_meta("some_df")
+    assert meta3.name == "susan/some_df"
+
+
+def test_board_rsc_path_to_pin_safe(board_short):
+    assert board_short.path_to_pin("me/some_pin") == "me/some_pin"
+
+
 # Manual Board Specific =======================================================
 
 from pins.boards import BoardManual  # noqa