Merge pull request #100 from machow/fix-pin-name-validate

fix(rsconnect): error in pin name starts with slash

Author: machow

pins/boards.py

@@ -770,7 +770,7 @@ def pin_versions_prune(self, *args, **kwargs):
         super().pin_versions_prune(*args, **kwargs)
 
     def validate_pin_name(self, name) -> None:
-        if name.count("/") > 1:
+        if name.count("/") > 1 or name.lstrip().startswith("/"):
             raise ValueError(f"Invalid pin name: {name}")
 
     def sort_pin_versions(self, versions) -> Sequence[VersionRaw]:

pins/tests/test_boards.py

@@ -31,6 +31,16 @@ def board(backend):
     backend.teardown()
 
 
+# misc ========================================================================
+
+
+def test_board_validate_pin_name_root(board):
+    with pytest.raises(ValueError) as exc_info:
+        board.path_to_pin("/some_pin")
+
+    assert "Invalid pin name" in exc_info.value.args[0]
+
+
 # pin_write ===================================================================