Skip to content

Commit a58ef09

Browse files
committed
feat: inform function for printing information
1 parent f9391b5 commit a58ef09

File tree

4 files changed

+20
-15
lines changed

4 files changed

+20
-15
lines changed

pins/boards.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515
from .meta import Meta, MetaRaw, MetaFactory
1616
from .errors import PinsError
1717
from .drivers import load_data, save_data, default_title
18+
from .utils import inform
19+
20+
21+
_log = logging.getLogger(__name__)
1822

1923

2024
# Note that once we drop python 3.7, we can make this a Protocol
@@ -292,6 +296,8 @@ def pin_write(
292296
"but that directory already exists."
293297
)
294298

299+
inform(_log, f"Writing to pin {repr(pin_name)}")
300+
295301
res = self.fs.put(tmp_dir, dst_version_path, recursive=True)
296302

297303
if dst_version_path == dst_pin_path:
@@ -391,9 +397,9 @@ def pin_versions_prune(
391397
# TODO(question): how to pin_inform? Log or warning?
392398
if to_delete:
393399
str_vers = ", ".join([v.version for v in to_delete])
394-
logging.info(f"Deleting versions: {str_vers}.")
400+
inform(_log, f"Deleting versions: {str_vers}.")
395401
if not to_delete:
396-
logging.info("No old versions to delete")
402+
inform(_log, "No old versions to delete")
397403

398404
for version in to_delete:
399405
self.pin_version_delete(name, version.version)

pins/cache.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
from .config import get_cache_dir
1313

14+
_log = logging.getLogger(__name__)
15+
1416

1517
# used if needed to preserve board path structure in the cache
1618
PLACEHOLDER_VERSION = "v"
@@ -65,7 +67,7 @@ def _make_local_details(self, path):
6567
# note that this is called in ._open(), at the point it's known the file
6668
# will be cached
6769
fn = super()._make_local_details(path)
68-
logging.info(f"cache file: {fn}")
70+
_log.info(f"cache file: {fn}")
6971
Path(fn).parent.mkdir(parents=True, exist_ok=True)
7072

7173
return fn
@@ -200,7 +202,7 @@ def prune(self, days=30):
200202
for path in to_prune:
201203
delete_version(to_prune)
202204

203-
logging.info("Skipping cache deletion")
205+
_log.info("Skipping cache deletion")
204206

205207

206208
def delete_version(path: "str | Path"):
@@ -213,7 +215,7 @@ def disk_usage(path):
213215

214216

215217
def prompt_cache_prune(to_prune, size) -> bool:
216-
logging.info(f"Pruning items: {to_prune}")
218+
_log.info(f"Pruning items: {to_prune}")
217219
human_size = humanize.naturalsize(size, binary=True)
218220
resp = input(f"Delete {len(to_prune)} pin versions, freeing {human_size}?")
219221
return resp == "yes"

pins/config.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
11
import appdirs
22
import os
33

4+
from types import SimpleNamespace
5+
46
PINS_NAME = "pins-py"
57
PINS_ENV_DATA_DIR = "PINS_DATA_DIR"
68
PINS_ENV_CACHE_DIR = "PINS_CACHE_DIR"
79
PINS_ENV_INSECURE_READ = "PINS_ALLOW_PICKLE_READ"
810

11+
pins_options = SimpleNamespace(quiet=False)
12+
913

1014
def get_data_dir():
1115
return os.environ.get(PINS_ENV_DATA_DIR, appdirs.user_data_dir(PINS_NAME))
@@ -29,12 +33,3 @@ def get_allow_pickle_read(flag):
2933
flag = bool(env_int)
3034

3135
return flag
32-
33-
34-
def _enable_logs():
35-
import logging
36-
37-
format = "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
38-
handlers = [logging.FileHandler("filename.log"), logging.StreamHandler()]
39-
40-
logging.basicConfig(level=logging.INFO, format=format, handlers=handlers)

pins/rsconnect/api.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
RSC_CODE_OBJECT_DOES_NOT_EXIST = 4
1919
RSC_CODE_INVALID_NUMERIC_PATH = 3
2020

21+
_log = logging.getLogger(__name__)
22+
2123

2224
def _download_file(response, local_fname):
2325
"""Download a potentially large file. Note that this mutates the response.
@@ -222,7 +224,7 @@ def _raw_query(self, url, method="GET", return_request=False, **kwargs):
222224

223225
headers = self._get_headers()
224226

225-
logging.info(f"RSConnect API {method}: {url} -- {kwargs}")
227+
_log.debug(f"RSConnect API {method}: {url} -- {kwargs}")
226228
r = self.session.request(method, url, headers=headers, **kwargs)
227229

228230
if return_request:

0 commit comments

Comments
 (0)