Enable reportIndexIssue in pyright (#313)

Author: nathanjmcdougall

pins/meta.py

@@ -2,7 +2,7 @@
 
 from dataclasses import InitVar, asdict, dataclass, field, fields
 from pathlib import Path
-from typing import ClassVar, Mapping, Sequence
+from typing import Any, ClassVar, Mapping, Sequence
 
 import yaml
 
@@ -104,7 +104,7 @@ def __getattr__(self, k):
         except KeyError:
             raise AttributeError(f"No metadata field not found: {k}")
 
-    def to_dict(self) -> Mapping:
+    def to_dict(self) -> dict[str, Any]:
         data = asdict(self)
 
         return data

pins/rsconnect/api.py

@@ -8,7 +8,7 @@
 from functools import partial
 from io import IOBase
 from pathlib import Path
-from typing import Generic, Sequence, TypeVar
+from typing import Generic, Literal, Sequence, TypeVar, overload
 from urllib.parse import urlencode
 
 import requests
@@ -215,7 +215,15 @@ def query(self, route, method="GET", return_request=False, **kwargs):
 
         return self._raw_query(endpoint, method, return_request, **kwargs)
 
-    def _raw_query(self, url, method="GET", return_request=False, **kwargs):
+    @overload
+    def _raw_query(
+        self, url, method, return_request: Literal[True], **kwargs
+    ) -> requests.Response: ...
+    @overload
+    def _raw_query(
+        self, url, method, return_request: Literal[False], **kwargs
+    ) -> dict | list: ...
+    def _raw_query(self, url, method="GET", return_request: bool = False, **kwargs):
         if "headers" in kwargs:
             raise KeyError("cannot specify headers param in kwargs")
 

pyproject.toml

@@ -103,7 +103,6 @@ reportArgumentType = false
 reportAttributeAccessIssue = false
 reportCallIssue = false
 reportIncompatibleMethodOverride = false
-reportIndexIssue = false
 reportMissingImports = false
 reportMissingTypeStubs = false
 reportOptionalMemberAccess = false